On 25 June 2013 15:42, <marti.ma...@littlecms.com> wrote: > So my question is why not to check "Name" before calling cmsDictAddEntry.
Yes, that's also a way to solve it, just two level deeper in indentation. :) >If I add a check for a parameter in this function, for consistency sake I > should add similar checks on nearly all lcms functions taking pointers. Well, I think it's a good idea to not assert() if a profile is invalid or corrupt. A "crashing" program isn't super-easy to debug, but one that issues a warning message is. > Please don't get me wrong, I would be glad to add this if it is really > necessary, but I feel it is like a temporary hack, and would change the > normal operation mode. If it helps, I'm happy to add this kind of fix for any of the broken profiles I come across. I just can't segfault colord for broken profiles, and I really don't want to sandbox lcms in a different process and use a secure IPC just to verify a profile from a performance point of view. Richard ------------------------------------------------------------------------------ This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev _______________________________________________ Lcms-user mailing list Lcms-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lcms-user
