Le 17 oct. 2012 à 19:10, Erich Titl a écrit : > Hi KP > > at 17.10.2012 17:31, KP Kirchdoerfer wrote: >> Am 17.10.2012 15:55, schrieb Erich Titl: >>> Hi Folks >>> >>> I was working with the openswan version in maint and had to make a few >>> adjustments to various files in that version, most to cater for safe >>> inclusion of the kernel module into moddb and one fix for the pluto >>> daemon to handle a broken android implementation. >>> >>> From my point of view this is a single commit, but this may be discussed. >>> >>> mega@luna:~/leaf/devel/leaf.new/bering-uclibc/source/openswan> git status >>> # On branch openswan >>> # Changes not staged for commit: >>> # (use "git add <file>..." to update what will be committed) >>> # (use "git checkout -- <file>..." to discard changes in working >>> directory) >>> # >>> # modified: ../../conf/sources.cfg >>> # modified: ../../repo/openswan/buildtool.cfg >>> # modified: ../../repo/openswan/buildtool.mk >>> # >>> # Untracked files: >>> # (use "git add <file>..." to include in what will be committed) >>> # >>> # ../../repo/openswan/openswan-2.6.38-android-ics-natoa.patch >>> >>> cheers >>> >>> Erich >> >> Hi Erich; >> >> you can always create a new remote branch and commit there to give us >> the chance to review the patches, if you are unshure. > > I am sure of the patches, just Yves had specific whishes towards > comments and commit pacing
I think you can make 1 commit with the first line has summary and then paragraph (starting with *) to describe specific changes. Also look at: http://sethrobertson.github.com/GitBestPractices/#usemsg and http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html about how to format the commit message. Like KP said if you are unsure push to a remote branch : erich-openswan-update with git push origin HEAD:erich-openswan-update I will reread your commit and merge it into main then sync your change into master Regards, Yves
smime.p7s
Description: S/MIME cryptographic signature
------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct
_______________________________________________ leaf-devel mailing list leaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/leaf-devel
