Hi John, I have finally found the time to look into this, and managed to reproduce the segfault that Álvaro noticed. It is caused by a call to fclose(0x0); This is very unexpected, shouldn't the C library check for NULL and return quietly?
Either way, I submitted the new patchset for you to review. br Josua Mayer Am 08.07.2016 um 07:47 schrieb John Crispin: > > On 07/07/2016 21:36, Josua Mayer wrote: >> Hi John, >> >> Could you please point me at where you merged my 2 patches? I want to >> ensure I am testing the same code that was causing segfaults. >> >> br >> Josua Mayer >> > > I already dropped them. > > John > >> Am 05.07.2016 um 14:33 schrieb Álvaro Fernández Rojas: >>> Hi Josua >>> >>> Not mounted rw. >>> Unfortunately I didn't have time to check it thoroughly and I didn't see >>> any remarkable messages. >>> >>> – Álvaro. >>> >>> El 5/7/16 a las 14:31, Josua Mayer escribió: >>>> Hi Álvaro, >>>> >>>> Am 05.07.2016 um 14:17 schrieb Álvaro Fernández Rojas: >>>>> It fails when trying to boot a Raspberry Pi, and then it segfaults when >>>>> calling mount_root without any parameters.\ >>>> How do you see it fail when it boots? Messages? / not mounted rw? >>>>> >>>>> – Álvaro >>>>> >>>>> El 5/7/16 a las 14:14, Josua Mayer escribió: >>>>>> Hi John, >>>>>> >>>>>> Am 05.07.2016 um 09:44 schrieb John Crispin: >>>>>>> On 30/06/2016 09:23, Álvaro Fernández Rojas wrote: >>>>>>>> I will try to test it on RPi tonight. >>>>>>>> >>>>>>>> Regards, >>>>>>>> Álvaro. >>>>>>>> >>>>>>>> El 30/6/16 a las 9:21, John Crispin escribió: >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> i have just merged to fstools patches into my staging tree that >>>>>>>>> address >>>>>>>>> a double mount issue and add back ext4 support. the ext4 patch >>>>>>>>> previously broke rPi and other ext4 targets, but i thini with josua's >>>>>>>>> patch applied it should work. i have done some basic testing already >>>>>>>>> my >>>>>>>>> end but would like further etst coverage to make sure there are no >>>>>>>>> hidden regressions >>>>>>>>> >>>>>>>>> things that should be tested are >>>>>>>>> >>>>>>>>> * does ext4 mount work on eMMC >>>>>>>>> * does rootfs mount work on rPi >>>>>>>>> * does extroot still work with flat mounts >>>>>>>>> * does extroot still work with flat overlay mounts >>>>>>>>> >>>>>>>>> i have only tested the last one so far. >>>>>>>>> >>>>>>>>> John >>>>>>>>> >>>>>>> Hi Josua, >>>>>>> >>>>>>> after applying your patches, users of flat ext4 are seeing segfaults >>>>>>> when calling mount_root >>>>>> when manually calling mount_root? With which parameters? >>>>>> I will certainly look into it though. >>>>>>> John >>>> >> >> _______________________________________________ >> Lede-dev mailing list >> Lede-dev@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/lede-dev >> _______________________________________________ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
