Hello Piotr and Karol,

On 11/29/2017 11:03 AM, Piotr Dymacz wrote:
Hello Karol,

Sorry for a late reply.

On 06.11.2017 18:58, Bizon wrote:
Hi Piotr,

  Thank You for comments.

Before sending v2 patch lets clarify all doubts.

2017-11-05 23:22 GMT+01:00 Piotr Dymacz <pep...@gmail.com>:
Hello Karol,

Thank you for your patch but it seems that it got whitespace mangled and
tabs were replaced with spaces. Please, send v2 using git send-email.

Also, please see my comments inline, below.

On 30.10.2017 20:32, Bizon wrote:

Add support for TP-Link TL-WDR7500 V6.

Specifications:
- WiSoC: QCA9563 - 3x3 2.4GHz
- Radio2: QCA9880 - 3x3 5GHz
- RAM: 64MB DDR2
- Storage: 8MB NOR SPI flash, can be replaced with 16M
- Switch: RTL8367S, now unmanaged
- Ethernet: 5x1G
- Misc: 2x button, 2x LED


Please, include in commit message how to install LEDE on this device as
described under "commit description" section on [1].

Ok, will prepare manual how to change bootloader to non-RSA one, move art and
install LEDE.

I'm sorry but I'm against accepting support for devices which requires such invasive modifications. We always try to make it possible for users to get back to the stock firmware which wouldn't be easy (or possible at all) with your changes in mtd layout and after bootloader swap.

In general, of course, I agree. However, we are seeing an increasing number of vendors (TP-Link and Ubiquiti, to name 2) using some form of locking in the bootloader to prevent loading of third-party firmware. The only option for loading OpenWRT (permanently - not using initramfs) on these devices will be replacing the bootloader, as Karol does in this patch.

If the only objection is that it involves invasive modifications that may not (probably won't) allow the device to be re-flashed to stock, I would prefer we accept the patch and make a very strongly-worded note in the ToH and the device's wiki page explaining the situation.

FWIW,

Bill

_______________________________________________
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Reply via email to