On Mon, Jan 25, 2010 at 10:48 PM, Ville M. Vainio <[email protected]> wrote:
>> A new unit test for _contentHashFile now passes "both ways", but only
>> after _contentHashFile takes care to convert both args to an encoded
>> string. Iirc, this may cause problems on ubuntu. We shall see.
>
> This is broken approach. Nothing should ever be encoded / decoded
> before passing it to contenthashfile. just the result of open("file",
> "rb").read()
Clearly, the headline must be converted to an encoded string.
Your point about the file's contents seems reasonable. I'll look
again at what I did. There is a unit test now, so all will be well if
it succeeds 4 ways: with Python 2.x/3.x on ubuntu/Windows 7.
Edward
--
You received this message because you are subscribed to the Google Groups
"leo-editor" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/leo-editor?hl=en.
