On Dec 13, 12:17 pm, "Edward K. Ream" <[email protected]> wrote:
> Rev 3772 allows proper mouseless operation of the qttabs gui.  In
> particular, the tab-cycle-next/previous commands now call
> c.outerUpdate() after calling c.bodyWantsFocusNow().

I had guessed that there may have been a problem with defining the
command with g.command, but the bug is/was more prosaic: c.doCommand
only calls c.outerUpdate for the *old* c.  It has no idea that the
command created a *new* c.  Thus the call to c.outerUpdate is (for
now) essential.

The proper fix is more global: changing all instances of body/
treeWantsFocusNow to body/treeWantsFocus.  This will be preparation to
make body/treeWantsFocusNow work (again) as expected, namely to call
c.outerUpdate immediately.

To be clear, the xWantsFocusNow methods are for rare special cases.
In almost all cases requesting that focus be set at the end of a
command is simplest and best because it reduces flicker.  Presumably
the present code could be simplified if Leo were only using the Qt
gui, but for now there is no need to do more than having the existing
code do what it says it does.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/leo-editor?hl=en.

Reply via email to