On Thu, 28 Jul 2011 11:52:06 -0500 "Edward K. Ream" <[email protected]> wrote:
> On Wed, Jul 27, 2011 at 10:19 AM, Terry Brown <[email protected]> wrote: > > Then, in a vanilla environment create this outline: > > > > @url link > > .../leo/test/test.leo# > > > > (except put the needed path in place of ...) > > > > double clicking the node should open test.leo in a new tab. Where's > > the focus? In the original, now concealed, tab editing the '@url link' > > headline. > > > > It may be that all that's needed is a call to c.endEditing() in the > > right place, although I thought you'd tried that. > > Rev 4440 of the trunk contains what is, imo, a clean solution to this problem: > > 1. baseNativeTree.onItemDoubleClicked now clears the 'self.selecting' > lockout before calling doHook. This allows the user-level event > handlers (including g.handleUrlInUrlNode) to redraw the screen. > > 2. g.handleUrlInUrlNode now calls c.endEditing and c.redraw_now() just > before opening another Leo outline (that is, just before the call to > g.openWithFileName. > > All unit tests pass, and I have been eating my own dog food without > problems. However, any such lockout-related change, no matter how > innocent looking, is in fact a major change to the code. Great, that was the kind of solution I thought should be possible but didn't want to attempt myself. > I'll be removing the timer hacks next. I still petition for retention of the 'suppress double single click until we know it's not a double click' hack in baseNativeTree with @settings keeping it off by default. If the @setting docs. explain the risk for people that want to turn it on, I don't think it's unreasonable. The timer in qtGui should certainly go, if the hidden tabs are no longer retaining focus. Cheers -Terry > Edward > -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en.
