On Thu, 28 Jul 2011 12:06:46 -0500 "Edward K. Ream" <[email protected]> wrote:
> On Thu, Jul 28, 2011 at 12:01 PM, Terry Brown <[email protected]> wrote: > > >> I'll be removing the timer hacks next. > > Done at rev 4441. > > > I still petition for retention of the 'suppress double single click > > until we know it's not a double click' hack in baseNativeTree with > > @settings keeping it off by default. If the @setting docs. explain the > > risk for people that want to turn it on, I don't think it's > > unreasonable. > > I really do not want this kind of code. Imo, it is not sound, and a > related setting would be exactly the kind of setting that Ville has > convinced me is not a good idea. I think Ville's setting wisdom is that features hidden by settings don't exist, which is exactly what you want for this feature :-) So the question is, should it be possible to bind both single and double click events to the tree? Without the timer, certain types of single click event will block double click events. The double click event code can't be expected to know how to roll back some unspecified single click event that started before it. If the user double clicks, they must want the double click effect, not the single click effect. When OP SegundoBob brought it up originally I thought perhaps it was a case of "you just can't do that", but then I found it's possible and useful. I'm sure this is done in other pointer driven UIs, click and double click are valuable bindings and it's a shame to lose one of them. I'd be less keen on keeping it if there was an obvious case where delaying a single click event by the OS's double click interval would cause trouble, but while I can certainly see in general such event ambiguity is undesirable, in this specific case the pay back seems to justify the cost. It's up to you of course, if you can't bear the thought of it lurking in the code, it can go. Nice work on getting rid of the focus snatching timer in qtGui - that one should definitely not have existed, I only did that because links which raise different tabs have become so key to my workflow and having your typing trash invisible headlines seemed worse than the timer hack, but only just :-) Cheers -Terry > Edward > -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en.
