On Fri, 29 Jul 2011 10:01:18 -0700 (PDT) "Edward K. Ream" <[email protected]> wrote:
> I've just done a trial merge of the free_layout branch into a clean > copy of the trunk. There is a lot to like in this branch and I'd like > to merge it into the trunk asap. > > Here are the results of the merge, in detail so we can both be on the > same page: > > 1. (Trivial) There was a harmless conflict in graphcanvas.py due to > our both adding a guard for c.db in slightly different ways. I've merged the trunk into the free_layout branch and will fix this and everything else there. > 2. (Minor) Opening most files, including test.leo and unitTest.leo, > gives this crash: > > Traceback (most recent call last): > File "c:\leo.repo\main-trunk\leo\core\leoPlugins.py", line 336, in > callTagHandler > result = handler(tag,keywords) > File "c:\leo.repo\main-trunk\leo\plugins\free_layout.py", line 57, > in loadLayouts > if '_ns_layout' in c.db: > AttributeError: 'Commands' object has no attribute 'db' I'm not seeing this - what's the context? > 3. (Minor, I think) The viewrendered command works, and the vr command > is shown by the command autocompleter, but the vr command is not > functional, or at least is not a synonym for the viewrendered command. > > Can you tell me what you intend for the vr command? I've made it a synonym for `viewrendered` again. > 4. (Somewhat important) I see that the viewrendered pane is shown > below the body pane, rather than to the right of the body pane. > > I presume there is some way to change this persistently, but I don't > know how... If you create it using the panel splitter context menu (aka known as the easter egg :-) it ends up wherever you indicated you wanted it. I've switched the default location when created from the Alt-X command to 'right-of' the body. The only issue here is that the view rendered pane is no longer a singleton thing, and the vr pane used for displaying plugin help is a different vr pane than one created by the user explicitly, and it's also placed right-of the body. But I think we can just let that alone for now and see how it evolves. > 5. (Important) Most aspects of the old viewrendered plugin do work: > movies, svg graphics, etc. good > 6. (Very Important) Even with viewrendered.py and free_layout.py > explicitly enabled, choosing a plugin from the plugins menu does not > print docstrings properly. A new pane appears to the right of the log > pane and body pane, and docutils generates many errors. > > This must be fixed before making the merge official. scrolled_message.py died, and I'll make sure it's not enabled anywhere in the branch before merge. I re-instated the use of the scrolledMessage hook, which I think had been commented out in favor of always using scrolled_message.py which had then been modified to maybe throw the torch to viewrendered :-) Now viewrendered registers the hook, but other things may do so as well. > 7. All unit tests pass. good > 8. The viewrendered buttons don't work quite a few design issues here, although nothing major I hope. the vr pane is no longer a singleton thing, so the method for addressing it needs to change. But to just have it work as before I think we can make these commands operate on the first pane found, usually there will be only one anyway (the plugin help display pane has a different object name, so it won't interfere). So I'd like to get lock / unlock / update and pause/play movie working, shouldn't be a problem. Hide / show / toggle I would like to dump in favor of a close command. I.e. when you want vr to appear you use the viewrendered or vr command, when you want it to go away you use the viewrendered-close command. Ok? Cheers -Terry -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en.
