On Jan 10, 9:59 pm, "Edward K. Ream" <[email protected]> wrote:

> ...The fix remembers the full path specified by the @<file> node,
> including any ancestor @path nodes.  This is better than nothing, but
> does not detect or otherwise deal with the case where a cloned @<file>
> nodes specifies two different paths.  That's a project for another
> time.

When I awoke this morning I saw the way forward.  Rather than
remembering a single path for each @<file> node, Leo should remember
*all* paths for each (possibly cloned) @<file> node.

To make this work, we will need a new method, say
at.rememberReadPath(fn,p), that appends fn to p.v.at_read.  Besides
eliminating duplicate code, rememberReadPath will be the focus of one
of two new unit tests: the other being a new test for
shouldPromptForDangerousWrite.  These two new unit tests are far from
a comprehensive test for all aspects of the prompt logic, but they are
also far better than nothing.

Furthermore, the coordination between rememberReadPath and
shouldPromptForDangerousWrite will be the explicit representation of
some subtle policy decisions about when to warn about changed paths in
@<file> nodes.  No need to discuss the details here.  We can discuss
the details later if the policy choices cause problems.

I expect to finish the next draft later tonight or tomorrow.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/leo-editor?hl=en.

Reply via email to