On Sun, Jan 29, 2012 at 4:35 PM, Edward K. Ream <[email protected]> wrote:
> Canonicalizing settings in the ctor appears to have created a buglet or two. The fix was to properly init a new dict. > it suggests an important new invariant: namely that canonicalizing an > already-canonicalized shortcut should be a no-op. Nice try, Edward. This would be a nice invariant, but it's not going to happen any time soon. Canonicalized settings were not designed with this invariant in mind. For example, shortcutFromSetting translates Shift-a to A, and A to a. Oops. Yes, it would be possible to change this *convention*, but that would instantly have ripple effects everywhere. It probably will never happen. In the meantime, the code must take care to canonicalize settings in exactly the right places. With the buglet fixed and the with no hope of making shortcutFromSetting safer, it looks like time to push the code. I plan to do this later tonight, after using the code myself for a bit longer. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en.
