On Mon, Jan 30, 2012 at 9:04 AM, Edward K. Ream <[email protected]> wrote:

>> > it suggests an important new invariant: namely that canonicalizing an 
>> > already-canonicalized shortcut should be a no-op.

> On second thought, this should actually be fairly easy to do safely.

This invariant is important because it is the doorway towards another
collapse in complexity.  The important thing is that internally almost
everything uses the strokes created by shortcutFromSetting.  It
doesn't much matter what convention is used--what matters is that all
the code knows that strokes *are* strokes.

This convention will have several important consequences:

1. I have just discovered that the very strange k.tkbindingFromStroke
is not needed.  That is, everything works if k.tkbindingFromStroke is
a do-nothing.  That's not too surprising, given that Tk is long gone,
but it's good to know.  I'll remove all traces of this beast after
some more testing...

2. Having strokes, and *only* strokes, be the result of the Qt
key-input methods should clarify the code considerably.  That's good,
because at present the code is a horror show.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/leo-editor?hl=en.

Reply via email to