On Wed, Aug 22, 2012 at 8:52 PM, Terry Brown <[email protected]> wrote: > Abbreviations can, in the branch > http://bazaar.launchpad.net/~terry-n-brown/+junk/leo_test > include computed values and place holders which you can step through, > filling in a template. Edward, these changes involve some core code, > although I think they're quite benign, but pls. see change notes at > the bottom of this email.
This is great work, Terry. Many thanks for it. Just installed the leo_test branch and have taken a careful look at the log. Here are my comments. 1. The exec statement in abbrevClass.finishCreate should be rewritten for Python3. Please make sure the code passes all unit tests when unitTest.leo is run with Python3. 2. The same exec statement appears to allow the execution of arbitrary Python code. I'm not sure how comfortable I am with that. Any comments? Aside from that, all looks well. Feel free to merge with the trunk after ensuring that the code works with Python 3. > Here's a quick screencast of the template expansions: I loved this screencast. Could you tell us the tool chain that you used to produce it? > Here are the draft docs. for abbreviations: Good work. I see that you merged them into LeoDocs.leo, which I like. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/leo-editor?hl=en.
