On Fri, 15 Aug 2014 08:48:48 -0400
Jacob Peck <[email protected]> wrote:

> On 8/14/2014 5:51 PM, 'Terry Brown' via leo-editor wrote:
> > But someone (Jacob?) still needs to update the code which prints the
> > build info. in the log window so that it displays that timestamp as
> > the Leo build ID.
> Done as of the current commit.  Leo now reports the following on
> startup:
> 
> Leo 4.11 final, build 20140815084439, Fri Aug 15 08:44:39 2014
> 
> Git repo info: branch = master, commit = 2cda89f4411b

Great, thanks - maintaining the sha1 output when available certainly
makes sense.

The problem that occurred to me later is with rogue committers like
edreamleo :-) who don't install the hooks - snapshot users will report
issues against 20140815084439 that occur in later commits.  But it
seems the number of committers is small enough we should be able to get
complete adoption.  It certainly solves the completely bogus version
reporting in snapshots.

Cheers -Terry

> Python 2.7.6, PyQt version 4.8.5
> Windows 7 x86 (build 6.1.7601) SP1
> 
> 
> That 'Git repo info' line  is replaced with 'Not running from a
> cloned git repo' if the user does not have a .git directory (i.e.,
> they downloaded a snapshot).
> 
> 
> The Git repo info has been helpful to me in the past when working on
> my own branches, so I wanted to retain it in some form.  It's
> computed in leoVersion.py and accessible from g.app.signon1, computed
> in leoApp.py.
> 
> 
> Thanks for this, Terry!  The hooks work great on cygwin :)
> 
> -->Jake
> 
> 

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at http://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Reply via email to