Rev 7151b2d completely refactors leoTree.selectHelper and its helpers, the most important code in Leo.
All tests pass, and I am happily eating my own dog food. The intention was simply to reorganize the code into separate helper methods. Nevertheless, there are **no** guarantees. Please report *any* new behavior in Leo immediately. It is especially important that you do so now. Edward P.S. The code is both tricky and crucial, which is why I have delayed so long in refactoring it. Nevertheless, this refactoring should have been done 5 years ago. The new code is way, way better than the old. Most importantly, each helper method has its own namespace, and that makes a big difference. For example, each helper's argument list shows exactly the relationships between variables in selectHelper and the helper. In retrospect, we can see just how "malicious" using section references can be. Yes, sections have their place, but not in code like this! P.P.S. It would not be an overstatement to say that delayed loading of large nodes *requires* the new refactoring. It would not have been safe to further complicate the old version of selectHelper. EKR -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
