On Thu, 27 Aug 2015 09:42:22 -0500 "Edward K. Ream" <[email protected]> wrote:
> On Wed, Aug 26, 2015 at 9:53 AM, john lunzer <[email protected]> wrote: > > > I've done limited testing. This is my first commit that is likely to > > affect many other people's daily flow. Please let me know if I've > > broken anything. > > > > I don't really care what kind of testing any developer does, as long > as they make *sure* to run all unit tests within a minute or two of a > push. I says this because I often push on Windows and then test on > my much-faster Linux machine. If a test fails, I then immediately > correct the trunk. I must admit that I don't always run the unit tests because sometimes I know there's no coverage in the area I'm working. But when I do, this is how I do it: Commit my changes locally, and then do rm -rf /tmp/.leo HOME=/tmp python launchLeo.py leo/test/unitTest.leo this runs vanilla Leo without my personal settings etc. Then I select the node "Active Unit Tests" and press Alt-4. Tests run, there's a count of failures in the console when it's done. Then I close Leo, check out the commit before my changes, usually `git checkout HEAD~1` and repeat. If the count of failures is the same before and after my changes I assume everything's ok. Remember to `git checkout master` to get your changes back. There seem to be 9-13 failures on my system currently, I don't think the test environment translates across machines perfectly. It would be nice if master typically had zero failures on it so you only needed to run tests post changes and evaluate new failures, but I think it might be a lot of work to get zero failures on arbitrary systems. Cheers -Terry > Furthermore, not all unit tests necessarily have to pass on all > platforms. Just make sure that no *new* unit tests fail as the result > of your new code. > > Edward > -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
