On Saturday, January 21, 2017 at 5:03:53 PM UTC-6, Edward K. Ream wrote: 1. Fix the various importer bugs. These have recently bit me. It would be > unbearable to let them hang around. I am going to re-enable the old python > importer code (using basescanner.py), to see whether the various > recently-reported importer bugs apply to it. >
Actually, the new python importer is substantially better than the old importer. *All *old importers suffered from a major bug in the perfect-import logic. As a result, perfect import checks passed when they should have failed. The latest version of basescanner.py fixes this bug. *Notes* #357 (@auto whitespace sensitivity, nodes not generated <https://github.com/leo-editor/leo-editor/issues/357>) appears to work fine, regardless of importer. It has been closed. A new unit test has been added. #260 (python import separates decorator from function <https://github.com/leo-editor/leo-editor/issues/360>) is minor for two reasons. First, multi-line decorators are rare. Second, a new unit test verifies that perfect import tests actually pass. So this is mostly a cosmetic issue. #364 (c.recursiveImport fails when generating @auto nodes <https://github.com/leo-editor/leo-editor/issues/364>) works *much* better with the new importers. About 40 files fail with the old importers. Only 5 files fail with the new importers. I'll investigate #364 a bit further, but I do not expect to spend much more time on Leo's importers. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
