On Thu, 16 Mar 2017 05:13:24 -0500 "Edward K. Ream" <[email protected]> wrote:
> On Thu, Mar 16, 2017 at 4:44 AM, Edward K. Ream > <[email protected]> wrote: > > It looks like removing tildes has broken background highlighting in > the status area. > > Rev 383484 restores leoSettings.leo from an earlier rev so that it > has tildes again. With only this change, the essential background > highlighting in the status area works again. > > I suspect that there is a bug in the stylesheet manager class > relating to tildes. The bug might be subtle. I think the blame lies entirely with Qt. http://doc.qt.io/qt-5.8/stylesheet-syntax.html clearly describes the use ~= just as we've been using it, without problems, prior to 5.8. For technical users, I'd say the best solution is pip3 install "PyQt5<5.8" until it's fixed. The problem from Leo's perspective is that 5.8 is now the default install (at least on Windows) and that's a hurdle for less technical users. The PyQt list responded to my minimal example code, https://gist.github.com/tbnorth/76191db825cc49dcca296ffb8d777047 reasonably pointing out that it's a Qt problem, not a PyQt problem. I'll try and get feedback from the Qt people. The question is does Leo need to code around the problem in the interim? Certain irony in this coming up just as the themes were given a work over. Assuming that Qt will fix ~= reasonably quickly and it would be nice to retain the expressiveness it provides, we could just add temporary code tagged with "# QT_TILDE" that (a) removes tildes in the stylesheet generated by expand_css_constants, and (b) explicitly styles elements in cases where c.styleSheetManager.mng.* methods are used - this wouldn't play nice with themes, but hopefully it would be short lived. I'll start with the Qt people. Cheers -Terry > I didn't write this code, and I don't want to touch it so soon before > b1. Terry, if you can fix the problem quickly, we can remove tildes > from leoSettings.leo before b1. It's up to you. > > Edward > -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
