On Wednesday, July 19, 2017 at 10:37:04 AM UTC-5, Edward K. Ream wrote:
>
> On Wednesday, July 19, 2017 at 9:12:34 AM UTC-5, Terry Brown wrote:
>
> > Don't forget Leo reads a lot of languages other than Python, not sure 
> how much of that code is relevant here. 
>
> Leo's read/write code works exactly the same for all languages. 
>

Your comment, Terry, was more accurate than mine.  There are at least two 
overly-specific parts of the following code:

def read_at_first_lines(analytics):
    flines = analytics[0]
    for i, line in flines:
        if line.startswith('#@' '+' 'leo'):
            break
        yield line

First, the '#' sign is language-specific.  There might even be a trailing 
delim.

Second, a thorough handling of the @+leo line would set flags indicating 
the format of the file.  Otoh, if Leo does transition to the new code, that 
might be a good time to remove support for ancient external file formats.

Such shortcuts are perfectly ok in a prototype, but it's good to mention 
them.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Reply via email to