On Sat, Nov 25, 2017 at 10:12 AM, Terry Brown <[email protected]> wrote:

I didn't mean to imply that you had started afresh. I meant that if one
> were to start afresh, one might arrange things as I went on to
> describe, but constrained by the need for backwards compatibility, you
> were trying to move in that direction by moving implementation to other
> files.
>

​Yes, that's correct.  Having commands be accessible​ via c is useful.  If
I had it all over again, I don't think I would prefer c.fileCommands.save
to c.save ;-)

the cleanup of the
> ​ ​
> namespace is a real improvement


​Yes, it's unexpectedly important. Devs can now see that *all* the methods
in the Commands class are there for a reason.
​

> while the reduction in size of the
> ​ ​
> definition of the Commands class kind of irrelevant, since Leo
> ​ ​
> eliminates any of the inconvenience of large source files.
>

​I really like the new commander*.py files, partly because they are smaller
(easier/faster to check via pylint) and partly because they are better
encapsulation.

Even such a smallish thing as imports matter. It's now clear which imports
each set of commands use. And they don't use many.

In short, this project is even more useful than I first imagined.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Reply via email to