Done. https://github.com/leo-editor/leo-editor/issues/603 & https://github.com/leo-editor/leo-editor/issues/604
2017-12-05 6:45 GMT+01:00 Matt Wilkie <[email protected]>: > Yeah one each is a bit much! One for user and one for develop will do. > > Thanks for your testing and feedback, it's appreciated. > > Matt > > On Mon, Dec 4, 2017 at 11:54 AM, Viktor Ransmayr < > [email protected]> wrote: > >> Hello Matt, >> >> Here's a quick summary of the results, when I tried to open the outlines >> from a pip(user) as well as a pip(developer) installation. >> >> <Log> >> >> ### Using leo-57-usr (installed using "pip install leo") >> >> Open all Leo-related outlines using "File >> Open Leo File >>" >> >> * CheatSheet.leo -> OK. >> * LeoDocs.leo -> Not OK. >> * LeoDist.leo -> Not OK. >> * leoPlugins.leo -> leoPluginsRef.leo -> Not OK. >> * leoPy.leo -> LeoPyRef.leo -> Not OK. >> * myLeoSettings.leo -> OK. >> * quickstart.leo -> OK. >> * scripts.leo -> OK. >> * leoSettings.leo -> OK. >> * unittest.leo -> Not found !!! >> >> ### Using leo-57-dev (installed using "pip install leo[develop]") >> >> Open all Leo-related outlines using "File >> Open Leo File >>" >> >> * CheatSheet.leo -> OK. >> * LeoDocs.leo -> Not OK. >> * LeoDist.leo -> Not OK. >> * leoPlugins.leo -> leoPluginsRef.leo -> Not OK. >> * leoPy.leo -> LeoPyRef.leo -> Not OK. >> * myLeoSettings.leo -> OK. >> * quickstart.leo -> OK. >> * scripts.leo -> OK. >> * leoSettings.leo -> OK. >> * unittest.leo -> Not found !!! >> >> </Log> >> >> Please let me know, if I should really create separate issues for each >> outline (& each mode?), that has missing files? >> >> >> 2017-12-03 19:31 GMT+01:00 Matt Wilkie <[email protected]>: >> >>> >>can not open: '@file C:\users\viktor\leo-57-dev\lib >>> \site-packages\leo\doc\html\index.html' <- !!! >>> >>> `.\leo\doc\html\*.*` is intentionally excluded. I surmise the reason to >>> be that these files are generated from LeoDoc.leo, so why make the download >>> bigger than it needs to be? I'm thinking the exclusion is greedier than it >>> needs to be, and that at the least `@file` and `@edit` nodes should be >>> included. Please do go ahead and open issues for the missing ref files (one >>> issue per .leo file, as they will each have quite different remedies). >>> >>> Thanks for the testing and feedback Viktor. >>> >>> Matt >>> >>> >>> >>> On Sat, Dec 2, 2017 at 12:46 AM, Viktor Ransmayr < >>> [email protected]> wrote: >>> >>>> @Matt: I just found out, that the same is true, if I'm opening the >>>> outline "LeoDocs.leo" >>>> >>>> <Log> >>>> >>>> Leo Log Window >>>> Leo 5.6, build 20171129062306, Wed Nov 29 06:23:05 CST 2017 >>>> Not running from a git repo >>>> Python 3.6.3, PyQt version 5.9.3 >>>> Windows 10 AMD64 (build 10.0.16299) SP0 >>>> isPython3: True >>>> caching enabled >>>> reading: C:\users\viktor\leo-57-dev\lib\site-packages\leo\doc\LeoDocs >>>> .leo >>>> reading: @auto-rst treecaching.txt >>>> reading: @edit conf.py >>>> file not found: C:\users\viktor\leo-57-dev\lib >>>> \site-packages\leo\doc\html\conf.py <- !!! >>>> reading: @file plugin_catalog.py >>>> can not open: '@file C:\users\viktor\leo-57-dev\lib >>>> \site-packages\leo\doc\html\index.html' <- !!! >>>> reading: @file slideshows.txt >>>> reading: @auto-md ../doc/demo.md >>>> reading: @auto-md ../doc/colorizer.md >>>> reading: @auto-md importers.md >>>> read 8 files in 3.22 seconds >>>> read outline in 3.67 seconds >>>> >>>> </Log> >>>> >>>> I do think, that these files should be accessible/ found, even if I'm >>>> not a Leo Developer. - Correct? >>>> >>>> >>>> 2017-11-26 6:37 GMT+01:00 Matt Wilkie <[email protected]>: >>>> >>>>> Thanks Viktor. >>>>> >>>>> This is a known issue, but yet to be documented up front where people >>>>> see it. Basically anything in the root folder of the leo-editor code >>>>> repository is not installed when using pip. This is because they need to >>>>> be >>>>> relative to `./leo-editor/leo` folder, which make them at the top of >>>>> `./site-packages`, and thus in the global namespace and not part of leo >>>>> (as >>>>> far as python is concerned). >>>>> >>>>> Before (source code repository view): >>>>> >>>>> leo-editor/leo/* # <-- this is actually Leo >>>>> leo-editor/pyflakes-leo.py # <-- this is an extra >>>>> >>>>> After (pip installed): >>>>> >>>>> .../site-packages/leo/* # <-- this is actually Leo >>>>> >>>>> One solution is to restructure the whole repository into what's called >>>>> the "src layout" (https://blog.ionelmc.ro/2014/05/25/python-packaging/). >>>>> That's a big change. >>>>> >>>>> Alternatively we could move pyflakes and friends into a `./leo/tools` >>>>> subfolder. That's a smaller change, but I don't know how it would impact >>>>> workflow of the people who use them; the change might not be small to >>>>> them. >>>>> >>>>> The decision last week was that people who use LeoPyRef would/should >>>>> be working with the complete development environment, either from a `git >>>>> clone {url} && pip install --editable {path}` or `pip --editable {url}`. >>>>> The thinking being that only people wanting to hack on Leo would be >>>>> interested in the file. Maybe that's not always true(?) >>>>> >>>>> Matt >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "leo-editor" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> To post to this group, send email to [email protected]. >>>>> Visit this group at https://groups.google.com/group/leo-editor. >>>>> For more options, visit https://groups.google.com/d/optout. >>>>> >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "leo-editor" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> To post to this group, send email to [email protected]. >>>> Visit this group at https://groups.google.com/group/leo-editor. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "leo-editor" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To post to this group, send email to [email protected]. >>> Visit this group at https://groups.google.com/group/leo-editor. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> -- >> You received this message because you are subscribed to the Google Groups >> "leo-editor" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To post to this group, send email to [email protected]. >> Visit this group at https://groups.google.com/group/leo-editor. >> For more options, visit https://groups.google.com/d/optout. >> > > -- > You received this message because you are subscribed to the Google Groups > "leo-editor" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > Visit this group at https://groups.google.com/group/leo-editor. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
