On Fri, Mar 2, 2018 at 9:27 PM, Matt Wilkie <[email protected]> wrote:
Generally speaking I should usually be the only one committing to master. >> And that should happen only when merging a release branch into master. >> > Vitalije and I agree that there are reasons for committing to master. See my previous comment on this thread. > https://github.com/leo-editor/leo-editor/settings/branches has settings >> for specifying the default branch and marking branches as protected (limit >> who's allowed to push, require signing, etc.). I haven't used any of these, >> but it looks useful for what we're talking about. >> > I played with those settings yesterday. master is now a protected branch, which basically means that push --force is not allowed. There are additional access restrictions, but those don't seem to matter much. Forbidding --force is a good thing, but now master does not show up on Leo's active branches page <https://github.com/leo-editor/leo-editor/branches/active>. Not sure why. It does show up on the all branches page <https://github.com/leo-editor/leo-editor/branches/all>. As you can see, there is a padlock besides the master branch. I also considered changing the default branch to devel, but when I started to do that a big red warning dialog said that doing so might have severe unintended consequences. So I didn't ;-) Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/leo-editor. For more options, visit https://groups.google.com/d/optout.
