I submitted a PR for one module in rst2pdf. We had about three months of discussions - and I discovered I had to make a change to my code update - before everyone was satisfied and the PR was approved. You can read through the thread and see how much went into it before the PR ended p being approved. That would never have happened without the PR process (and my original change wouldn't always have worked). Here's the thread -
https://github.com/rst2pdf/rst2pdf/pull/826 On Saturday, August 22, 2020 at 10:46:42 AM UTC-4, Edward K. Ream wrote: > > > > On Fri, Aug 21, 2020 at 9:36 PM Thomas Passin <[email protected] > <javascript:>> wrote: > >> I'm not crazy about bureaucracy, but I have noticed that the PR can lead >> to a lot of good discussion, and what gets added in the end may not be >> exactly what was in the PR at the start. >> > > Imo, "bureaucracy" is a misleading word. True, PR's require more work. The > question is, when is the work justified? > > As you say, PR's provide a platform for discussion and review. They are > typically a permanent record of particular code changes. As we consider Leo > without me, I think PR's will help democratize changes. Looking back, a PR > for the fast read code that I "borrowed" from Vitalije might have avoided > some hard feelings. > > Edward > -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/44dc45b1-9c8d-4327-9f77-fe702c5f9793o%40googlegroups.com.
