On Tue, Dec 7, 2021 at 2:10 PM vitalije <[email protected]> wrote: > I've added more comments in the code and have created PR to merge > importers into devel branch. >
Thanks for this. This is PR #2353 <https://github.com/leo-editor/leo-editor/pull/2353>. I have assigned it to Leo 6.6. In general, I like what I see: - The simpler interface between Leo (app.scanner_for_at_auto & app. scanner_for_ext) and the do_import method in each scanner. This change accounts for most of the 33 changed files. - Importers use a lines-based interface by default, rather than a string-based interface. This affects mostly linescanner.py, but there are simple related changes in some, but not all, of the importers. Here are my remaining conditions of satisfaction for this PR: - The new importer should use the vnode_dict interface. This will allow the importer to connect to the post-pass. - The new importer should import all of mypy's .py files, including all test files. At rev 7b109931aa, the importer crashes for 81 mypy files. There is no indication elsewhere that the crash has occurred. There probably should be. The ekr-improve-old-importer branch will contain new post pass of the old importer. Unless I am mistaken, the new importer should benefit from this work. At any rate, I have questions about my own code that I want to resolve. Edward -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/CAMF8tS20767OWXC2LUF-snkk%3DS%2BxCCOvafWVWKf-ts%3D-fmy%3D_w%40mail.gmail.com.
