I think the new way it works agrees with the principle of minimum surprise. At least, I was always surprised when Shift-Down *didn't* select the last line. And with this change, a down arrow without a Shift puts the cursor at the end of the last line, which is also what I seem to expect.
I suppose an alternative would have been to have Shift-Down insert a new line at the bottom and select to there, but I didn't favor that because an unrequested insert can be a surprise - and when the selected line gets deleted, which has to be the most common use case, should the newly inserted line be deleted too? Hmm.... I'd rather not make it configurable unless someone complains. Why complicate the code when chances are everyone will like the new way, if they even notice? On Monday, June 27, 2022 at 4:00:10 PM UTC-4 jkn wrote: > That is how I would explain the desired action, and thank you for working > on the PR (and Edward for raising it); I will try it shortly. > > I would suggest that it is made a configurable option; as I mention I am > sure I have seen something like this as a configurable option > in A.N.Other editor. I am trying to remember which. It may be that the new > action is annoying to some. > > It was probably connected with the idea of 'virtual space; whether you can > navigate with the cursor beyond the end of text > in a node. Leo doesn't let you do this. Some editors do; then if you start > adding characters, they fill the space between > the previous end of text in that node, and your current cursor position, > with a combination of EOLs and spaces. > > I see that Notepad++ has an 'enable scrolling beyond last line' option, > which is probably similar. Note that > (I'm not requesting this feature for Leo... > > Thanks, J^n > > > On Monday, June 27, 2022 at 4:02:25 PM UTC+1 [email protected] wrote: > >> I understand that the desired action is this: >> >> If the cursor is on the last line of the body and SHIFT-DOWN is >> pressed, then the selection will be extended to include the entire last >> line. >> The cursor will also move to the end of the last line. >> >> Is there anything else that should happen, or any other user action that >> should be included? >> >> >> >> On Monday, June 27, 2022 at 9:28:29 AM UTC-4 Edward K. Ream wrote: >> >>> On Monday, June 27, 2022 at 8:23:38 AM UTC-5 Edward K. Ream wrote: >>> >>> I agree this can be annoying. Do you want to attempt a fix? >>>> >>> >>> I have just created #2697 >>> <https://github.com/leo-editor/leo-editor/issues/2697> for this issue. >>> >>> Edward >>> >> -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/544c211f-bd51-4d1c-8049-7110a64ba615n%40googlegroups.com.
