Just tried it BTW - seems to be working fine, thanks!
On Wednesday, June 29, 2022 at 3:13:12 PM UTC+1 [email protected] wrote: > And thanks for giving us the little nudge we needed to work on it : ) > > On Wednesday, June 29, 2022 at 9:42:51 AM UTC-4 jkn wrote: > >> Thanks for the work on this little itch! >> >> Regard, Jon N >> >> >> On Wednesday, June 29, 2022 at 12:37:28 PM UTC+1 [email protected] wrote: >> >>> The new PR has been merged into devel. >>> >>> On Wednesday, June 29, 2022 at 12:10:57 AM UTC-4 [email protected] >>> wrote: >>> >>>> OK, a fix is proposed in PR 2700 >>>> <https://github.com/leo-editor/leo-editor/pull/2700>. It wasn't an >>>> off-by-one. It was a missing bit of logic. I needed to restrict the >>>> movement to the end of the last line to the case where the cursor was >>>> already on the last line when the Down key is pressed. I have also tested >>>> using a wrapped last line and it works correctly in this case, too. >>>> >>>> On Tuesday, June 28, 2022 at 11:41:19 PM UTC-4 [email protected] wrote: >>>> >>>>> Hmm, this is not quite working as I want. If you place the cursor in >>>>> the left-hand column of a line above the last line, and Shift-Down to the >>>>> last line, the cursor jumps to the end of the last line. It should go to >>>>> the start of the last line. This seems different from what I thought I >>>>> had >>>>> worked out. I'll look at fixing it - probably an off-by-one error or >>>>> some >>>>> such. >>>>> >>>>> On Tuesday, June 28, 2022 at 6:34:12 PM UTC-4 [email protected] wrote: >>>>> >>>>>> @Edward has merged the PR. >>>>>> >>>>>> On Tuesday, June 28, 2022 at 1:12:03 PM UTC-4 Edward K. Ream wrote: >>>>>> >>>>>>> On Tue, Jun 28, 2022 at 11:33 AM Jacob MacDonald <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>> In the tbp directory, you need to run `git checkout >>>>>>>> tbp-leo-general` and then should see the new code. >>>>>>>> >>>>>>> >>>>>>> Thanks, Jacob. That worked. >>>>>>> >>>>>>> Edward >>>>>>> >>>>>> -- You received this message because you are subscribed to the Google Groups "leo-editor" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/leo-editor/29b07708-6817-4873-a687-74d98d2261e9n%40googlegroups.com.
