Hi,
Your patches look really interesting, and we would really appreciate
having them. However, it is a basic "law" in distributed programming
that changes are provided in "small" patches often rather than in
one big patch after several weeks/months.
The reason for this is that smaller changes are easier to find bugs
in, easier to understand, and avoids code conflicts between developers
working on the same files/functions.
So it would be really great if you could breakup your patches into
those that you mentioned below (or even smaller if it makes sence).
This is particularly interesting for me in the TextWidget area as
I am currently trying to make this widget comply with output from
test/lib/text/test15.c, which would make it's behaviour more
Motif 1.2 compliant.
However if you give us only 1 big patch, then trying to integrate
your code with mine will not be easy.
I18n support in Text is one of the really big features in XmText
that has been missing/requested.
CP
Kazuyuki Funada wrote:
>
> Hi,
>
> > We like to know what we're changing; the patch on your web site
> > does more than changing i18n in XmText/XmTextField. Maybe that's
> > described in the document, unfortunately I can't read Japanese.
> > There's fixes to List.c which definitely don't improve i18n.
>
> Sorry, there are no document about changes yet. I will put comments
> into code.
>
> Current patch includes the below changes.
>
> - i18n support(for XmTextWidget, XmTextFieldWidget)
> - Improve Highlighting especially MULTILINE_TEXT.
> - Improve text selection(Cut & Paste)
> - Fixes some issues related to Netscape(dynMotif Version)
>
> And I am also trying to improve DnD behavior now...
>
> > The things I'd like to see changed are :
> > - we like to stick to the data structures that we currently have;
> > they closely resemble the ones in Motif, we'd like to avoid
> > adding fields. Your code adds a couple of fields (max_char_width,
> > fontset); my question is would it be possible to work without them.
> > - There are a couple of global variables in XmIm.c. I *definitely*
> > don't like that :-)
> >
> > So to summarise : we *do* want your fixes; we'd like them to obey
> > some rules, please help us get there...
> >
> > Did I say "thank you" yet ? :-)
>
> OK.
> I will try that my changes satisfy Lesstif's law:-)
> However, I am just a Sunday programmer. So, I need the time
> (4W or more)to do that.
>
> Thanks.
>
> --
> Kazuyuki
