Andrew Benton wrote:
Jim Gifford wrote:
Andrew Benton wrote:
Sysklog-1.4.1 seems to have a problem with asm/atomic.h
If it includes asm/processor.h then the sysklog build errors out like
this
andy:/sources/sysklogd-1.4.1$ make
gcc -O3 -DSYSV -fomit-frame-pointer -Wall -fno-strength-reduce
-DSYSLOG_INET -DSYSLOG_UNIXAF -DNO_SCCS -DFSSTND
-DSYSLOGD_PIDNAME=\"syslogd.pid\" -c syslogd.cgcc -O3 -DSYSV
-fomit-frame-pointer -Wall -fno-strength-reduce -c pidfile.c
gcc -s -o syslogd syslogd.o pidfile.o
gcc -O3 -DSYSV -fomit-frame-pointer -Wall -fno-strength-reduce
-DFSSTND -c klogd.c
gcc -O3 -DSYSV -fomit-frame-pointer -Wall -fno-strength-reduce
-DALLOW_KERNEL_LOGGING -c syslog.c
gcc -O3 -DSYSV -fomit-frame-pointer -Wall -fno-strength-reduce
-DFSSTND -c ksym.c
gcc -O3 -DSYSV -fomit-frame-pointer -Wall -fno-strength-reduce
-DFSSTND -c ksym_mod.c
In file included from /usr/include/asm/atomic.h:5,
from module.h:31,
from ksym_mod.c:97:
/usr/include/asm/processor.h:70: error: ‘CONFIG_X86_L1_CACHE_SHIFT’
undeclared here (not in a function)
/usr/include/asm/processor.h:70: error: requested alignment is not a
constant
make: *** [ksym_mod.o] Error 1
If I remove the #include <asm/processor.h> and #include
<linux/compiler.h> from <asm/atomic.h> then everything builds fine.
Andy
Thanx Andrew, wondering why I never got this error. I'm looking into a
fix right now.
Another solution is to alter the patch we apply to sysklogd.
<asm/atomic.h> is pulled in by the module.h file created by the
sysklogd-1.4.1-fixes-1.patch. We could alter that to also create an
atomic.h file in the sysklogd sources and include that instead of
/usr/include/asm/atomic.h.
Andy
Actually, I don't think atomic.h is needed. This was discussed
elsewhere in this thread. That include was added Mar 31, 2004 to
overcome a problem with linux-2.4 and 2.6. See the comments at the top
of ksym_mod.c. The LSB's patch does not include atomic.h either, but I
can't recall the reason to use the debian patch over the LSB one.
-- DJ Lucas
--
http://linuxfromscratch.org/mailman/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page
