On 8/9/07, Greg Schafer <[EMAIL PROTECTED]> wrote:
> Dan Nicholson wrote:
>
> >> sed -i.bak '/THIS_SH/s,$, </dev/tty,' tests/run-test
> >
> > Seems more appropriate. I was trying to avoid another command, but
> > it's "the right thing to do". I'll try to push that in.
> >
> > I wanted to ask you about this, though. What's the reason you don't
> > hit this in DIY?
>
> Actually, I do hit it, just not all the time. And no, I don't redirect
> </dev/null while building. A contributing factor seems to be whether the
> build is scripted or interactive. An LFS style build (as root) doesn't hit
> it when scripted but a Pacman based build (where everything is built
> unprivileged) does hit it. Kinda makes sense now that I think about it :-/
> Anyhoo, hopefully this tweak will DTRT in all circumstances.
I think it will DTRT. It's really a silly test, anyway, since it's not
for bash to decide what the ACLs on the standard fds currently are.
The subsequent two tests, `test -w /dev/stdout' and `test -w
/dev/stderr' are already useless, too, because the script is being run
>/tmp/xx 2>&1 :) It would seem to be a better test if they created a
file descriptor with known permissions and then did std{in,out,err}
tests on that.
--
Dan
--
http://linuxfromscratch.org/mailman/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page
