Qrux wrote:
> On Feb 25, 2012, at 9:14 AM, Bruce Dubbs wrote:

> Still, it seems awfully specious to say: "It's only the number of
> files that needs to coincide; everything else is gravy."  The files
> are indeed supposed to be match the interfaces; that's why there are
> exactly as many as are interfaces that you want to start. 

Not true:

ifconfig.eth0
ifconfig.eth0:2

Both use IFACE=eth0.

Also, the user has the option of ONBOOT=no so there is the capability to 
manually do ifdown x && ifup y using the same IFACE.


I do like using BRIDGE.

+   test -n "${MTU}" -a $MTU -eq $MTU -a 0 -lt $MTU 2> /dev/null
                         ^^^^^^^^^^^^^

What does the 2nd segment do?  If you are testing for MTU being an 
integer, the 3rd segment will do that.  Perhaps it would be better to 
issue an error statement if the argument is not formatted correctly:

if test -n "${MTU}"; then
   if [[ ${MTU} =~ ^[0-9]+$ ]] -a [[ $MTU -ge 68 ]] ; then
     ip link set dev ${IFACE} mtu $MTU
   else
     echo "Invalid MTU $MTU"
   fi
fi

Another issue is how to handle the case when the user wants to add eth0 
and eth1 to the bridge?  I don't think we do that properly in ifup 
although bridge tries to handle it.

   -- Bruce
-- 
http://linuxfromscratch.org/mailman/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page

Reply via email to