On Feb 26, 2012, at 9:05 AM, Bruce Dubbs wrote:

> Qrux wrote:
>> On Feb 25, 2012, at 8:12 PM, Bruce Dubbs wrote:
>> 
>>> Qrux wrote:
>>> 
>>>> Probably something like:
>>>> 
>>>>    BRIDGE_PORTS="eth0 eth1"
>>> It's getting complicated.  We then need to consider address1, dhcp2, 
>>> etc.  What we have now works for kvm, but a general solution is more 
>>> difficult.
>> 
>> No...I think you're thinking about an IP_FORWARD dual-homed
>> situation, which would be two separate ifconfig.{X,Y} files.  A
>> bridge doesn't have that configuration.  It's a single IP for the
>> bridge interface, not the two separates ports.  Should look like
>> this:
> 
> I was mixing up the concepts although a bridge can certainly have more 
> than 2 connections.  For our bridge, I agree that we only need to 
> support one ethx port.

Yes.  I used two because I'm not an ASCII-art-pro, but the patch I posted deals 
with an arbitrary number of interfaces--all which share a single IP config when 
enslaved to the same bridge interface.

> I'll look at your other comment later.  What I want to do is make sure 
> ifup/down is correct for the upcoming 7.1 release.  The rest goes in 
> BLFS and can wait a few days if needed.

Sure.  Typo in ifup: line 114 should read like this:

    RIGHT --> M=$(echo $MTU | awk -v idx=$PHY_IDX '{printf("%s", $idx);}')

But, the one I sent you read like this (the typo is quite a barrel-of-monkeys):

    WRONG --> M=$(echo $MTU | awk -v idx=$PHY_IDX '{printf("%s", $idk);}')

Agreed about 7.1.

* * *

For 7.2 & beyond...

Bridge-utils is not dissimilar from udev, in that it's a userspace tool for a 
kernel.  And, it's certainly no less optional than inettools.  In fact, brctl 
probably most resembles blockdev in util-linux.

Plus, given the high coupling (2-way dependencies on core stuff: /sbin/ifup, 
/sbin/ifdown, and /lib/lsb/ipv4-static) it seems natural that it ought to 
migrate to LFS, precisely because it can help guide the issues that have come 
up with "chained" network services.  That, in turn, will ease the way for other 
projects/books to include multi-step network setups like bonding or PPPoE.

Ethtool is the same story...another userspace kernel tool to inspect hardware.  
It replaces mii-tool, now deprecated.  At the very least, we ought to remove 
the install of that particular executable from the book.  Mii-tools cannot 
report link speeds above 100BaseT (an interesting bug I didn't realize until it 
bit me while debugging a network).  Again, more "core" than inettools, and 
about the same as blockdev in util-linux.

So, I propose bridge-utils and ethtool be moved into LFS.

        Q

-- 
http://linuxfromscratch.org/mailman/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page

Reply via email to