On 02/18/2014 05:15 AM, Armin K. wrote:
> On 02/18/2014 03:24 AM, kre...@higgs.linuxfromscratch.org wrote:
>> Author: krejzi
>> Date: Mon Feb 17 18:24:31 2014
>> New Revision: 10478
>>
>> Log:
>> Random fixes.
>>
>
> Bruce, you might be interested in some of the changes below for LFS,
> too. The {a,so} instead of {so,a} is being used for consistency with
> other packages. Moving from two to one lines is being used for no good
> reason, except that sed instructions use that approach too.
>
You have missed 3 trivial fixes:
>>
>> Modified: branches/systemd/BOOK/chapter05/xz.xml
>> ==============================================================================
>> --- branches/systemd/BOOK/chapter05/xz.xml Mon Feb 17 09:40:52 2014
>> (r10477)
>> +++ branches/systemd/BOOK/chapter05/xz.xml Mon Feb 17 18:24:31 2014
>> (r10478)
>> @@ -41,7 +41,7 @@
>> </sect2>
>>
>> <sect2 role="installation">
>> - <title>Installation of Xz-Utils</title>
>> + <title>Installation of Xz</title>
>>
Title says Xz-Utils, rest of the page says Xz. Chapter 6 has Xz as
title. Consistency
>> <para>Prepare Xz for compilation:</para>
>>
>>
>> Modified: branches/systemd/BOOK/chapter06/flex.xml
>> ==============================================================================
>> --- branches/systemd/BOOK/chapter06/flex.xml Mon Feb 17 09:40:52 2014
>> (r10477)
>> +++ branches/systemd/BOOK/chapter06/flex.xml Mon Feb 17 18:24:31 2014
>> (r10478)
>> @@ -141,12 +140,12 @@
>> </listitem>
>> </varlistentry>
>>
>> - <varlistentry id="libfl.so">
>> - <term><filename class="libraryfile">libfl.so</filename></term>
>> + <varlistentry id="libfl">
>> + <term><filename class="libraryfile">libfl</filename></term>
>> <listitem>
>> <para>The <filename class="libraryfile">flex</filename>
>> library</para>
>> - <indexterm zone="ch-system-flex libfl.so">
>> - <primary sortas="c-libfl.so">libfl.so</primary>
>> + <indexterm zone="ch-system-flex libfl">
>> + <primary sortas="c-libfl">libfl</primary>
>> </indexterm>
>> </listitem>
>> </varlistentry>
>>
This is with consistency with other packages. They don't list the
extension if library is .so.
>> Modified: branches/systemd/BOOK/chapter06/mpfr.xml
>> ==============================================================================
>> --- branches/systemd/BOOK/chapter06/mpfr.xml Mon Feb 17 09:40:52 2014
>> (r10477)
>> +++ branches/systemd/BOOK/chapter06/mpfr.xml Mon Feb 17 18:24:31 2014
>> (r10478)
>> @@ -43,9 +43,9 @@
>>
>> <para>Prepare MPFR for compilation:</para>
>>
>> -<screen><userinput remap="configure">./configure --prefix=/usr \
>> - --enable-thread-safe \
>> -
>> --docdir=/usr/share/doc/mpfr-&mpfr-version;</userinput></screen>
>> +<screen><userinput remap="configure">./configure --prefix=/usr \
>> + --enable-thread-safe \
>> + --docdir=/usr/share/doc/mpfr-&mpfr-version;</userinput></screen>
>>
>> <para>Compile the package:</para>
>>
>>
This package has two whitespaces between ./configure and --prefix=/usr,
so I changed it to just one.
--
Note: My last name is not Krejzi.
--
http://linuxfromscratch.org/mailman/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page
