On 2018-08-12 13:03 +0100, Ken Moffat wrote: > On Sun, Aug 12, 2018 at 02:19:39PM +0800, Xi Ruoyao wrote: > > On 2018-08-11 18:07 +0100, Ken Moffat wrote: > > > I'm running all the tests (except for vim - I think that dislikes my > > > use of urxvt) and I wasn't intending to look at the results until > > > later (this build is experimental, to see how much, if any, damage > > > is caused by various potential BLFS updates). But for grep 'make > > > check' unexpectedly failed (status 1) after an XFAIL. > > > > > > XFAIL triple-backref (exit status: 1) > > > > It's a good thing. Glibc-2.28 fixed a bug so this test should not > > FAIL now. See thread > > <http://lists.gnu.org/archive/html/bug-grep/2018-08/msg00000.html>. > > > > The other backref test (alt-backref) should not fail and it didn't. > > But I don't pay any attention to unexpected passes (XPASS) and I > don't think we normally mention them.
It "should" abort because a Glibc bug in 2015. In Glibc-2.28 the bug is finally fixed. > [...] > > > > > > Looking at the log from the same version (3.1) when I last built it, > > > the main tests had two XFAIL, backref-alt and triple-backref but > > > WITHOUT an assertion failure. > > > > I rebuilt grep-3.1 on my LFS-8.2 with Glibc-2.27. Both > > triple-backref and backref-alt aborted because of fail assertions. > > Please recheck your result. > > > > On my 20180726 system the results were as I said, no sign of any > messages for them except XFAIL, and the tests completed with normal > status. `grep -B1 Aborted test-suite.log` then you'll see the two tests fail because of assertion fail. > > > > The "main" test "failed" (XPASS in fact) then `make` just bailed out. > > With "make check -k" gnulib-test would run. > > > > We can > > > > sed '/^am__append_2/d' -i tests/Makefile > > > > after configuring Grep, or just use "make check -k" and tell the > > audiences there would be a XPASS test with Glibc-2.28. > Using 'make -k check' sounds plausible. The issue is grep test suite considers XPASS as failure. I think it makes the test suite a fragile "status detector". In the next release of grep backref-alt has been removed from XPASS list. If I recall, several other packages also have XPASS but they do not consider XPASS as failure. -- Xi Ruoyao <[email protected]> School of Aerospace Science and Technology, Xidian University -- http://lists.linuxfromscratch.org/listinfo/lfs-dev FAQ: http://www.linuxfromscratch.org/faq/ Unsubscribe: See the above information page
