al...@verizon.net wrote:
Hi Bruce,
On Tue Nov 15 2011 at 15:12:33 MST
... we've made some improvements and fixed some bugs in the bootscripts. ...
Thank you for the excellent "lfs-bootscripts-20111114" release.
At the risk of sounding picayunish (just striving for an even higher
perfection), I do have some (exceedingly trivial - and not necessarily
meaningful) comments on the 'console' module.
1. There's no "exit 0" at the end (after "esac").
For consistency (might apply to a few other modules).
That isn't necessary. It's done by default. I admit that some scripts
do it and some don't but either way is OK.
2. For "Native English speakers", the 'Usage: ...' branch is never reached
(for them, the script "dies" at 'if [ -z "${KEYMAP}" ... exit 0'.
Some clever "dummy" construct right at the top might satisfy everyone.
I don't really use this script, so can you test it for me? Just try the
attached file.
3. For the fortunate multitude who don't speak English natively, I believe
a simple <echo "Usage: ${0} {start}">, instead of
<echo $"Usage:" "${0} {start}">, might work as well.
Yes, This is a bug. Fixed.
4. If you ever (future, future) find the above comments worth a second of
your busy time, you might want to insert the start paren on 'cleanfs' module,
Description: ... optionally) /tmp.
That paren should be a comma. It will automatically get fixed with the
next bootscript update.
-- Bruce
#!/bin/sh
########################################################################
# Begin console
#
# Description : Sets keymap and screen font
#
# Authors : Gerard Beekmans - ger...@linuxfromscratch.org
# Alexander E. Patrakov
# DJ Lucas - d...@linuxfromscratch.org
# Update : Bruce Dubbs - bdu...@linuxfromscratch.org
#
# Version : LFS 7.0
#
########################################################################
### BEGIN INIT INFO
# Provides: console
# Required-Start:
# Should-Start: $local_fs
# Required-Stop:
# Should-Stop:
# Default-Start: S
# Default-Stop:
# Short-Description: Sets up a localised console.
# Description: Sets up fonts and language settings for the user's
# local as defined by /etc/sysconfig/console.
# X-LFS-Provided-By: LFS
### END INIT INFO
. /lib/lsb/init-functions
# Native English speakers probably don't have /etc/sysconfig/console at all
[ -r /etc/sysconfig/console ] && . /etc/sysconfig/console
function is_true()
{
[ "$1" = "1" ] || [ "$1" = "yes" ] || [ "$1" = "true" ]
}
failed=0
case "${1}" in
start)
# See if we need to do anything
if [ -z "${KEYMAP}" ] && [ -z "${KEYMAP_CORRECTIONS}" ] &&
[ -z "${FONT}" ] && [ -z "${LEGACY_CHARSET}" ] &&
! is_true "${UNICODE}"; then
exit 0
fi
# There should be no bogus failures below this line!
log_info_msg "Setting up Linux console..."
# Figure out if a framebuffer console is used
[ -d /sys/class/graphics/fb0 ] && use_fb=1 || use_fb=0
# Figure out the command to set the console into the
# desired mode
is_true "${UNICODE}" &&
MODE_COMMAND="echo -en '\033%G' && kbd_mode -u" ||
MODE_COMMAND="echo -en '\033%@\033(K' && kbd_mode -a"
# On framebuffer consoles, font has to be set for each vt in
# UTF-8 mode. This doesn't hurt in non-UTF-8 mode also.
! is_true "${use_fb}" || [ -z "${FONT}" ] ||
MODE_COMMAND="${MODE_COMMAND} && setfont ${FONT}"
# Apply that command to all consoles mentioned in
# /etc/inittab. Important: in the UTF-8 mode this should
# happen before setfont, otherwise a kernel bug will
# show up and the unicode map of the font will not be
# used.
for TTY in `grep '^[^#].*respawn:/sbin/agetty' /etc/inittab |
grep -o '\btty[[:digit:]]*\b'`
do
openvt -f -w -c ${TTY#tty} -- \
/bin/sh -c "${MODE_COMMAND}" || failed=1
done
# Set the font (if not already set above) and the keymap
[ "${use_fb}" == "1" ] || [ -z "${FONT}" ] || setfont $FONT || failed=1
[ -z "${KEYMAP}" ] ||
loadkeys ${KEYMAP} >/dev/null 2>&1 ||
failed=1
[ -z "${KEYMAP_CORRECTIONS}" ] ||
loadkeys ${KEYMAP_CORRECTIONS} >/dev/null 2>&1 ||
failed=1
# Convert the keymap from $LEGACY_CHARSET to UTF-8
[ -z "$LEGACY_CHARSET" ] ||
dumpkeys -c "$LEGACY_CHARSET" | loadkeys -u >/dev/null 2>&1 ||
failed=1
# If any of the commands above failed, the trap at the
# top would set $failed to 1
( exit $failed )
evaluate_retval
exit $failed
;;
*)
echo "Usage: ${0} {start}"
exit 1
;;
esac
# End console
--
http://linuxfromscratch.org/mailman/listinfo/lfs-support
FAQ: http://www.linuxfromscratch.org/lfs/faq.html
Unsubscribe: See the above information page
