Hi Justin, On Sun, Apr 3, 2011 at 5:27 PM, Justin Ruggles <[email protected]> wrote: > On 04/03/2011 07:23 PM, Ronald S. Bultje wrote: >> I agree. What did you have in mind as "compromise solution"? I can >> come up with weird stuff like a header file that contains the actual >> private AVOption table entries as individual macros (#define >> MIN_PREDICTION_ORDER_OPT { bla, bla, "bla", bla } ), and then using >> that. That's a little ugly/evil though. Can you think of something >> cleaner? > > That's actually not too bad. Documentation would still be duplicated, > but I guess that's part of the compromise. I was originally thinking > more along the lines of a threshold for number of codecs using the > option before it becomes shared, but your idea seems like less of a > maintainance burden.
Yeah, that's a good point. I basically just don't want to set "number of codecs" too low, e.g. if an option is used by MSMPEG4v1/2/3 and DivX 3.11, does that make it "global"? What if it's shared by MPEG-4 and H.264, or VP8 and H.264, or MPEG-1 and MPEG-2? What if it's shared by half, or all of the above? (I don't really know, and it's not really necessary to discuss for this particular patch, but still would be good to think about for when it does come up.) Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
