Hi, On Mon, Apr 4, 2011 at 11:35 AM, Justin Ruggles <[email protected]> wrote: > On 04/04/2011 11:30 AM, Ronald S. Bultje wrote: >> On Mon, Apr 4, 2011 at 3:21 PM, Justin Ruggles <[email protected]> >> wrote: >>> On 04/02/2011 01:19 PM, Anton Khirnov wrote: >>>> +#if FF_API_FLAC_GLOBAL_OPTS >>>> /** >>>> * Determines which LPC analysis algorithm to use. >>>> * - encoding: Set by user >>>> * - decoding: unused >>>> */ >>>> - enum AVLPCType lpc_type; >>>> + attribute_deprecated enum AVLPCType lpc_type; >>> >>> Should we also deprecate the AVLPCType enum and move it to lpc.h without >>> the AV prefix? I don't think private options need to have public enums >>> for their values. >> >> Does AVOption attempt to solve this in any way? I.e., does AVOption >> have a mechanism to link a string to a numerical value to create a >> "enum-style" list of (random) integers and (meaningful) strings? > > yes.
Then the answer to your original question is yes also. Can I (or you) commit (and first OK) Anton's original patch? I'm not very familiar with this code so would prefer if somebody else reviewed it. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
