On Tue, Apr 05, 2011 at 03:30:10AM -0600, Nathan Caldwell wrote: > On Tue, Apr 5, 2011 at 2:28 AM, Nathan Caldwell <[email protected]> wrote: > > On Tue, Apr 5, 2011 at 2:08 AM, Kostya <[email protected]> wrote: > >> On Tue, Apr 05, 2011 at 01:55:58AM -0600, Nathan Caldwell wrote: > >>> On Tue, Apr 5, 2011 at 1:44 AM, Kostya <[email protected]> wrote: > >>> > On Tue, Apr 05, 2011 at 01:05:23AM -0600, Nathan Caldwell wrote: > >>> >> + pctx->pe.min = 8192.0f; /* FIXME: 0.8 * 10 * FRAME_LENGTH_LONG > >>> >> * bandwidth / (sample_rate / 2) */ > >>> >> + pctx->pe.max = 12288.0f; /* FIXME: 1.2 * 10 * FRAME_LENGTH_LONG > >>> >> * bandwidth / (sample_rate / 2) */ > >>> > > >>> > what prevents you from using those numbers in fixme? > >>> > >>> Our encoder doesn't have any concept of a cutoff, thus our bandwidth > >>> == sample rate / 2. If/when a cutoff is added I would like to keep > >>> track of what needs to be adjusted. > >> > >> Oh, it had that (remember IIR filter to degrade quality?). > > > > Hmm, it is used, but not unless it's explicitly set. Guess I'll go and fix > > that. > > Updated patch attached. > > I had other bugs in the further perceptual entropy reduction section I > had to fix as well.
looks good to me (even if I don't know a thing about it) _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
