On Tue, Apr 5, 2011 at 11:52 AM, Alex Converse <[email protected]> wrote: > On Tue, Apr 5, 2011 at 12:55 AM, Nathan Caldwell <[email protected]> wrote: >> On Tue, Apr 5, 2011 at 1:44 AM, Kostya <[email protected]> wrote: >>> On Tue, Apr 05, 2011 at 01:05:23AM -0600, Nathan Caldwell wrote: >>>> + pctx->pe.min = 8192.0f; /* FIXME: 0.8 * 10 * FRAME_LENGTH_LONG * >>>> bandwidth / (sample_rate / 2) */ >>>> + pctx->pe.max = 12288.0f; /* FIXME: 1.2 * 10 * FRAME_LENGTH_LONG * >>>> bandwidth / (sample_rate / 2) */ >>> >>> what prevents you from using those numbers in fixme? >> >> Our encoder doesn't have any concept of a cutoff, thus our bandwidth >> == sample rate / 2. If/when a cutoff is added I would like to keep >> track of what needs to be adjusted. > > > Perhaps you can create a "const float bandwidth = sample_rate * 0.5f;" > and use it where you have those fixmes. Then there is only one thing > to update.
Check the updated patch ;). -- -Nathan Caldwell _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
