On Sun, Apr 10, 2011 at 12:20:03AM +0300, Martin Storsjö wrote:
> On Sat, 9 Apr 2011, Anton Khirnov wrote:
> 
> > ---
> >  libavformat/avio.h |   12 ++++++++----
> >  1 files changed, 8 insertions(+), 4 deletions(-)
> > 
> > diff --git a/libavformat/avio.h b/libavformat/avio.h
> > index b30866c..e1c4876 100644
> > --- a/libavformat/avio.h
> > +++ b/libavformat/avio.h
> > @@ -43,10 +43,14 @@
> >   * sizeof(AVIOContext) must not be used outside libav*.
> >   */
> >  typedef struct {
> > -    unsigned char *buffer;
> > -    int buffer_size;
> > -    unsigned char *buf_ptr, *buf_end;
> > -    void *opaque;
> > +    unsigned char *buffer;  /**< Start of the buffer. */
> > +    int buffer_size;        /**< Maximum buffer size */
> > +    unsigned char *buf_ptr; /**< Current position in the buffer */
> > +    unsigned char *buf_end; /**< End of the data, may be less that 
> > buffer+buffer_size
> 
> s/that/than/
> 
> > +                                 e.g. for packetized formats which read 
> > one packet
> > +                                 when filling the buffer. */
> 
> I'd word this slightly differently. "Packetized" formats sounds like 
> something RTPish to me, while this can occur for any case where the 
> underlying read function returned less than requested (EOF, or no more 
> data available without blocking, as for network streams).
> 
> What about:
> 
> End of the data, may be less than buffer+buffer_size if the read function 
> returned less data than requested, e.g. for streams where no more data has 
> been received yet.
> 

Thanks for comments, pushed all patches with those changes.

-- 
Anton Khirnov

Attachment: signature.asc
Description: Digital signature

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to