Hi, On Sun, Apr 10, 2011 at 2:15 AM, Anton Khirnov <[email protected]> wrote: > On Sat, Apr 09, 2011 at 05:03:34PM -0400, Ronald S. Bultje wrote: >> Hi, >> >> On Sat, Apr 9, 2011 at 8:57 AM, Anton Khirnov <[email protected]> wrote: >> > --- >> > libavformat/avio.h | 10 +++++----- >> > 1 files changed, 5 insertions(+), 5 deletions(-) >> >> This mostly looks OK. >> >> If you (optionally) want to document more: >> >> > unsigned long checksum; >> > unsigned char *checksum_ptr; >> > unsigned long (*update_checksum)(unsigned long checksum, const uint8_t >> > *buf, unsigned int size); >> >> This allows generating or validating a CRC-or-similar-style checksum >> over input / output data. Callers should normally not need to touch >> the function pointer directly, but would rather just use the utility >> functions provided. >> >> > int (*read_pause)(void *opaque, int pause); >> > int64_t (*read_seek)(void *opaque, int stream_index, >> > int64_t timestamp, int flags); >> >> And for these, normally applications would have no business touching >> them directly. If they do, it's likely a bug. >> > > People implementing custom I/O might want to set them. Patch for that > attached. [..] > + * @note None of the function pointers in AVIOContext should be called > + * directly, they should only be set by the client application > + * when implementing custom I/O.
I would add: Normally these are set to the function pointers specified in avio_alloc_context(). Otherwise OK, thanks. Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
