On 04/15/2011 11:26 AM, Kirill Gavrilov wrote:
[..window support patch..]

I like the file.c patch a lot, a little less the cmdutils.c one.
Comments interleaved.

> diff --git a/cmdutils.c b/cmdutils.c
> index 5b7b508..6654a31 100644
> --- a/cmdutils.c
> +++ b/cmdutils.c
> @@ -155,6 +155,59 @@ static const OptionDef* find_option(const OptionDef *po, 
> const char *name){
>      return po;
>  }
>  
> +#if(defined(_WIN32) || defined(__WIN32__))
> +void prepare_app_arguments(int *argc_ptr, char ***argv_ptr)

parse_options() is the only consumer of argv/argc might be better call
the function from it.


> +#if(defined(_WIN32) || defined(__WIN32__))
> +#include <windows.h>
> +
> +int ff_open_file(const char *filenameUtf8, int oflag, int pmode)

Maybe redefining open in windows might be another option (so other
systems remain untouched.

lu

-- 

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero

_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to