On Fri, 22 Apr 2011, Måns Rullgård wrote:
> "Ronald S. Bultje" <[email protected]> writes:
>
> > Hi,
> >
> > On Thu, Apr 21, 2011 at 5:48 PM, Martin Storsjö <[email protected]> wrote:
> >> Setting this should fix the FATE build failure on DragonFly BSD,
> >> since inet_aton only is visible if __BSD_VISIBLE is set.
> >>
> >> Alternatively, a line defining __BSD_VISIBLE=1 could be
> >> added at the top of os_support.c. For FreeBSD, similar lines
> >> are required in libavdevice/bktr.c and libavdevice/oss_audio.c, too.
> >> ---
> >> doc/general.texi | 4 ++--
> >> 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > Can't we detect BSD subtype automatically and set __BSD_VISIBLE=1
> > directly? Mans/Diego?
>
> __BSD_VISIBLE should not be set directly, IIRC. _BSD_SOURCE is the
> correct symbol to define. This can be done with add_cppflags -D_BSD_SOURCE
> in the relevant OS sections in configure.
Yes, the *_VISIBLE macros sound like things that shouldn't be set
manually. Nevertheless, defining _BSD_SOURCE isn't enough for getting the
inet_aton prototype on DragonFly at least.
// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
