On date Wednesday 2011-04-13 08:20:30 +0200, Anton Khirnov encoded: > From: Stefano Sabatini <[email protected]> > > With the following additions: > * support to anti-aliased glyph rendering > * support to UTF-8 text and Unicode chars rendering > * support for RGB packed formats > * fix minor errors and typos in the filter description > * extend/clarify examples in the filter description > > Signed-off-by: Anton Khirnov <[email protected]> [...] > +static int glyph_cmp(void *key, const void *b) > +{ > + const Glyph *a = key, *bb = b; > + int64_t diff = (int64_t)a->code - (int64_t)bb->code; > + return diff > 0 ? 1 : diff < 0 ? -1 : 0; > +}
Nit: key->a, b->bb is a little schizofrenic ... The changes look fine, but I consider the idea of picking a patch and randomly fixing it very bad, indeed this is making very hard to spot the differences with the original and spoiling authorship/blame information. I suggest to apply the original patch, and apply the fixes on top of that, this also helps the original contributor to review and eventually port the various fixes. _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
