On 05/04/2011 02:05 AM, Stefano Sabatini wrote: > The changes look fine, but I consider the idea of picking a patch and > randomly fixing it very bad, indeed this is making very hard to spot > the differences with the original and spoiling authorship/blame > information.
The signed off tag means that the first person to be contacted about a commit is the undersigned, then the author. > I suggest to apply the original patch, and apply the fixes on top of > that, this also helps the original contributor to review and > eventually port the various fixes. I'd rather not have multiple commits just because the patch imported wasn't reviewed when it hit some foreign tree... lu -- Luca Barbato Gentoo/linux http://dev.gentoo.org/~lu_zero _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
