On Sun, May 15, 2011 at 07:21:59PM +0100, Måns Rullgård wrote: > Diego Biurrun <[email protected]> writes: > > > > --- a/libavcodec/fft-internal.h > > +++ b/libavcodec/fft-internal.h > > @@ -19,6 +19,8 @@ > > #ifndef AVCODEC_FFT_INTERNAL_H > > #define AVCODEC_FFT_INTERNAL_H > > > > +#include "fft.h" > > + > > #if CONFIG_FFT_FLOAT > > Are you sure this doesn't break something? That header is one of those > slightly magical ones.
It does not break FATE. What else do you want me to test for? > > --- a/libswscale/x86/swscale_template.h > > +++ b/libswscale/x86/swscale_template.h > > @@ -18,10 +18,13 @@ > > * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA > > 02110-1301 USA > > */ > > > > - > > #ifndef SWSCALE_X86_SWSCALE_TEMPLATE_H > > #define SWSCALE_X86_SWSCALE_TEMPLATE_H > > Unrelated. Yes, but does it matter? It does not make the patch less readable and it's hardly worth cluttering the commit log for ... > > +#include <stdint.h> > > + > > +#include "libavutil/mem.h" > > + > > Probably OK, but the _template files really shouldn't be tested for > standalone build. It doesn't make sense. This one may look like a template, but it is not. It should really be renamed to something more sensible. I propose asm_constants.h, but Ronald wants me to hold off for moment because he has many changes pending. I'll send a patch that eliminates the multiple inclusion of this file. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
