Diego Biurrun <[email protected]> writes:

> Add missing #includes, skip compiling .h files that are not real headers.
> ---
>  libavcodec/aac_tablegen_decl.h |    2 ++
>  libavcodec/fft-internal.h      |    2 ++
>  libavcodec/mathops.h           |    1 +
>  libavcodec/mpc.h               |    4 +++-
>  libavcodec/put_bits.h          |    1 +
>  libavformat/network.h          |    3 +++
>  libswscale/Makefile            |    2 ++
>  7 files changed, 14 insertions(+), 1 deletions(-)
>
> diff --git a/libavcodec/aac_tablegen_decl.h b/libavcodec/aac_tablegen_decl.h
> index ce4ecb5..a2a2bc1 100644
> --- a/libavcodec/aac_tablegen_decl.h
> +++ b/libavcodec/aac_tablegen_decl.h
> @@ -23,6 +23,8 @@
>  #ifndef AAC_TABLEGEN_DECL_H
>  #define AAC_TABLEGEN_DECL_H
>  
> +#include "config.h"
> +
>  #if CONFIG_HARDCODED_TABLES
>  #define ff_aac_tableinit()
>  extern const float ff_aac_pow2sf_tab[428];

Why does this file exist at all?

> diff --git a/libavcodec/fft-internal.h b/libavcodec/fft-internal.h
> index d30571b..b997887 100644
> --- a/libavcodec/fft-internal.h
> +++ b/libavcodec/fft-internal.h
> @@ -19,6 +19,8 @@
>  #ifndef AVCODEC_FFT_INTERNAL_H
>  #define AVCODEC_FFT_INTERNAL_H
>  
> +#include "fft.h"
> +
>  #if CONFIG_FFT_FLOAT
>  
>  #define FIX15(v) (v)

This feels wrong even if it doesn't break anything as such.

> diff --git a/libavcodec/mathops.h b/libavcodec/mathops.h
> index d74bc1e..98c9acf 100644
> --- a/libavcodec/mathops.h
> +++ b/libavcodec/mathops.h
> @@ -23,6 +23,7 @@
>  #define AVCODEC_MATHOPS_H
>  
>  #include "libavutil/common.h"
> +#include "config.h"
>  
>  #if   ARCH_ARM
>  #   include "arm/mathops.h"

OK

> diff --git a/libavcodec/mpc.h b/libavcodec/mpc.h
> index eea4b6d..51fd72a 100644
> --- a/libavcodec/mpc.h
> +++ b/libavcodec/mpc.h
> @@ -29,13 +29,15 @@
>  #ifndef AVCODEC_MPC_H
>  #define AVCODEC_MPC_H
>  
> +#include <stdint.h>
> +
>  #include "libavutil/lfg.h"
>  #include "avcodec.h"
>  #include "get_bits.h"
>  #include "dsputil.h"
>  #include "mpegaudio.h"
> +#include "mpegaudiodsp.h"
>  
> -#include "mpcdata.h"

Oh great, another one of those.  Removing it is of course correct, but
doesn't fit the commit message.

>  #define BANDS            32
>  #define SAMPLES_PER_BAND 36
> diff --git a/libavcodec/put_bits.h b/libavcodec/put_bits.h
> index c426540..3849e6d 100644
> --- a/libavcodec/put_bits.h
> +++ b/libavcodec/put_bits.h
> @@ -34,6 +34,7 @@
>  #include "libavutil/intreadwrite.h"
>  #include "libavutil/log.h"
>  #include "mathops.h"
> +#include "config.h"

OK

>  //#define ALT_BITSTREAM_WRITER
>  //#define ALIGNED_BITSTREAM_WRITER
> diff --git a/libavformat/network.h b/libavformat/network.h
> index 881384c..da44be0 100644
> --- a/libavformat/network.h
> +++ b/libavformat/network.h
> @@ -21,7 +21,10 @@
>  #ifndef AVFORMAT_NETWORK_H
>  #define AVFORMAT_NETWORK_H
>  
> +#include <errno.h>
> +
>  #include "config.h"
> +#include "libavutil/error.h"
>  #include "os_support.h"

Probably OK.

>  #if HAVE_WINSOCK2_H
> diff --git a/libswscale/Makefile b/libswscale/Makefile
> index 7f8f721..556a91a 100644
> --- a/libswscale/Makefile
> +++ b/libswscale/Makefile
> @@ -16,6 +16,8 @@ OBJS-$(HAVE_MMX)           +=  x86/rgb2rgb.o            \
>                                 x86/yuv2rgb_mmx.o
>  OBJS-$(HAVE_VIS)           +=  sparc/yuv2rgb_vis.o
>  
> +SKIPHEADERS = x86/swscale_template.h
> +

OK

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to