"Ronald S. Bultje" <[email protected]> writes:

> Hi,
>
> On Tue, May 17, 2011 at 1:29 PM, Diego Biurrun <[email protected]> wrote:
>> On Tue, May 17, 2011 at 05:24:24PM +0100, Mans Rullgard wrote:
>>> +typedef struct MPADSPContext {
>>> +    void (*apply_window_float)(float *synth_buf, float *window,
>>> +                               int *dither_state, float *samples, int 
>>> incr);
>>> +    void (*apply_window_fixed)(int32_t *synth_buf, int32_t *window,
>>> +                               int *dither_state, int16_t *samples, int 
>>> incr);
>>> +    void (*dct32_float)(float *dst, const float *src);
>>> +    void (*dct32_fixed)(int *dst, const int *src);
>>> +} MPADSPContext;
>>
>> unrelated comment: Will we keep typedeffing structs forever?
>
> Yes please, saves 7 characters ("struct ") every time you define/cast
> a variable of this type. Imagine that we added "signed int" instead of
> "int" every time we declared one.

I'm not buying that argument, and I'll gladly remove the typedef.  I put
it there mostly to please the consistency nazis.

-- 
Måns Rullgård
[email protected]
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to