Diego Biurrun <[email protected]> writes: > On Thu, May 19, 2011 at 03:59:46PM +0100, Måns Rullgård wrote: >> Diego Biurrun <[email protected]> writes: >> >> > Add missing #includes, skip compiling .h files that are not real headers. >> > >> > --- a/libavcodec/aac_tablegen_decl.h >> > +++ b/libavcodec/aac_tablegen_decl.h >> > @@ -23,6 +23,8 @@ >> > #ifndef AAC_TABLEGEN_DECL_H >> > #define AAC_TABLEGEN_DECL_H >> > >> > +#include "config.h" >> > + >> > #if CONFIG_HARDCODED_TABLES >> > #define ff_aac_tableinit() >> > extern const float ff_aac_pow2sf_tab[428]; >> >> Why does this file exist at all? > > I have no idea as I did not create it. But untangling that maze is > way outside the scope of this patch.
Pasting the contents into the only place that uses it shouldn't be too hard. You already did that with another header. >> > --- a/libavcodec/fft-internal.h >> > +++ b/libavcodec/fft-internal.h >> > @@ -19,6 +19,8 @@ >> > #ifndef AVCODEC_FFT_INTERNAL_H >> > #define AVCODEC_FFT_INTERNAL_H >> > >> > +#include "fft.h" >> > + >> > #if CONFIG_FFT_FLOAT >> > >> > #define FIX15(v) (v) >> >> This feels wrong even if it doesn't break anything as such. > > Fine, let's leave feelings aside then. :) Gee, how do I have to shout? THAT CHANGE IS NOT OK!!!! GET IT?!?!?!?! >> > --- a/libavcodec/mpc.h >> > +++ b/libavcodec/mpc.h >> > @@ -29,13 +29,15 @@ >> > #ifndef AVCODEC_MPC_H >> > #define AVCODEC_MPC_H >> > >> > +#include <stdint.h> >> > + >> > #include "libavutil/lfg.h" >> > #include "avcodec.h" >> > #include "get_bits.h" >> > #include "dsputil.h" >> > #include "mpegaudio.h" >> > +#include "mpegaudiodsp.h" >> > >> > -#include "mpcdata.h" >> >> Oh great, another one of those. Removing it is of course correct, but >> doesn't fit the commit message. > > Here's a replacement: > > Fix 'make checkheaders' target. > > Add missing #includes, remove excessive ones and skip compiling .h files > that are not real headers. The subject line is still misleading. -- Måns Rullgård [email protected] _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
