> Based on the output with and without this patch it is clear that you > have broken implicit SBR+Implicit PS. > > Regards, > Alex
Now file nr 2 sounded fine. MvH Benjamin Larsson
>From a3bd86034fb90eb8bf3e8e693fa1c137de2da9d4 Mon Sep 17 00:00:00 2001 From: Benjamin Larsson <[email protected]> Date: Tue, 24 May 2011 15:11:57 +0200 Subject: [PATCH] Add support for aac streams in mp4/mov without extradata. --- libavcodec/aacdec.c | 40 ++++++++++++++++++++++++++++++++++++++++ libavformat/utils.c | 22 ++++++++-------------- 2 files changed, 48 insertions(+), 14 deletions(-) diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c index 5f9dd83..3c4f3f6 100644 --- a/libavcodec/aacdec.c +++ b/libavcodec/aacdec.c @@ -530,6 +530,22 @@ static void reset_all_predictors(PredictorState *ps) reset_predict_state(&ps[i]); } +static int sample_rate_idx (int rate) +{ + if (92017 <= rate) return 0; + else if (75132 <= rate) return 1; + else if (55426 <= rate) return 2; + else if (46009 <= rate) return 3; + else if (37566 <= rate) return 4; + else if (27713 <= rate) return 5; + else if (23004 <= rate) return 6; + else if (18783 <= rate) return 7; + else if (13856 <= rate) return 8; + else if (11502 <= rate) return 9; + else if (9391 <= rate) return 10; + else return 11; +} + static void reset_predictor_group(PredictorState *ps, int group_num) { int i; @@ -551,10 +567,32 @@ static av_cold int aac_decode_init(AVCodecContext *avctx) ac->m4ac.sample_rate = avctx->sample_rate; if (avctx->extradata_size > 0) { + avctx->channels = 0; + avctx->frame_size = 0; + avctx->sample_rate = 0; if (decode_audio_specific_config(ac, ac->avctx, &ac->m4ac, avctx->extradata, avctx->extradata_size) < 0) return -1; + } else { + int sr,i=-1; + enum ChannelPosition new_che_pos[4][MAX_ELEM_ID]; + + sr = sample_rate_idx(avctx->sample_rate); + ac->m4ac.sampling_index = sr; + ac->m4ac.channels = avctx->channels; + + for (i=0 ; i<8 ; i++) + if (ff_mpeg4audio_channels[i] == avctx->channels) + break; + if (i==-1) { + av_log(avctx, AV_LOG_ERROR, "chan_config not found, channels = %d.\n", avctx->channels); + return -1; + } + ac->m4ac.chan_config = i; + + set_default_channel_config(avctx, new_che_pos, ac->m4ac.chan_config); + output_configure(ac, ac->che_pos, new_che_pos, ac->m4ac.chan_config, OC_GLOBAL_HDR); } avctx->sample_fmt = AV_SAMPLE_FMT_S16; @@ -2499,6 +2537,7 @@ AVCodec ff_aac_decoder = { .sample_fmts = (const enum AVSampleFormat[]) { AV_SAMPLE_FMT_S16,AV_SAMPLE_FMT_NONE }, + .capabilities = CODEC_CAP_CHANNEL_CONF, .channel_layouts = aac_channel_layout, }; @@ -2519,5 +2558,6 @@ AVCodec ff_aac_latm_decoder = { .sample_fmts = (const enum AVSampleFormat[]) { AV_SAMPLE_FMT_S16,AV_SAMPLE_FMT_NONE }, + .capabilities = CODEC_CAP_CHANNEL_CONF, .channel_layouts = aac_channel_layout, }; diff --git a/libavformat/utils.c b/libavformat/utils.c index 67aa76a..11b2112 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -2161,11 +2161,7 @@ int av_find_stream_info(AVFormatContext *ic) for(i=0;i<ic->nb_streams;i++) { AVCodec *codec; st = ic->streams[i]; - if (st->codec->codec_id == CODEC_ID_AAC) { - st->codec->sample_rate = 0; - st->codec->frame_size = 0; - st->codec->channels = 0; - } + if (st->codec->codec_type == AVMEDIA_TYPE_VIDEO || st->codec->codec_type == AVMEDIA_TYPE_SUBTITLE) { /* if(!st->time_base.num) @@ -2183,13 +2179,6 @@ int av_find_stream_info(AVFormatContext *ic) assert(!st->codec->codec); codec = avcodec_find_decoder(st->codec->codec_id); - /* Force decoding of at least one frame of codec data - * this makes sure the codec initializes the channel configuration - * and does not trust the values from the container. - */ - if (codec && codec->capabilities & CODEC_CAP_CHANNEL_CONF) - st->codec->channels = 0; - /* Ensure that subtitle_header is properly set. */ if (st->codec->codec_type == AVMEDIA_TYPE_SUBTITLE && codec && !st->codec->codec) @@ -2329,8 +2318,13 @@ int av_find_stream_info(AVFormatContext *ic) /* if still no information, we try to open the codec and to decompress the frame. We try to avoid that in most cases as it takes longer and uses more memory. For MPEG-4, we need to - decompress for QuickTime. */ - if (!has_codec_parameters(st->codec) || !has_decode_delay_been_guessed(st)) + decompress for QuickTime. + + If CODEC_CAP_CHANNEL_CONF is set this will force decoding of at + least one frame of codec data, this makes sure the codec initializes + the channel configuration and does not only trust the values from the container. + */ + if (!has_codec_parameters(st->codec) || !has_decode_delay_been_guessed(st) || st->codec->codec->capabilities & CODEC_CAP_CHANNEL_CONF) try_decode_frame(st, pkt); st->codec_info_nb_frames++; -- 1.7.1
_______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
