On Tue, May 24, 2011 at 15:28:46 (CEST), Benjamin Larsson wrote:

>> Based on the output with and without this patch it is clear that you
>> have broken implicit SBR+Implicit PS.
>> 
>> Regards,
>> Alex
>
> Now file nr 2 sounded fine.
>
> MvH
> Benjamin Larsson
>
> From a3bd86034fb90eb8bf3e8e693fa1c137de2da9d4 Mon Sep 17 00:00:00 2001
> From: Benjamin Larsson <[email protected]>
> Date: Tue, 24 May 2011 15:11:57 +0200
> Subject: [PATCH] Add support for aac streams in mp4/mov without extradata.

Unfortunately, this patch breaks fate:

TEST    bfi
--- /home/siretart/libav/libav/tests/ref/fate/bethsoft-vid      2011-05-21 
15:05:26.928798109 +0200
+++ tests/data/fate/bethsoft-vid        2011-05-24 21:57:16.719211885 +0200
@@ -1,141 +0,0 @@
-0, 0, 192000, 0x00000000
-1, 0, 1480, 0x00000000
-0, 1500, 192000, 0x01a6cf45
-0, 3000, 192000, 0xd07d57e9
-0, 4500, 192000, 0x3cb1dff5
-1, 5994, 1480, 0x20a92bd4
-0, 6000, 192000, 0xd1aaa8fb
-0, 7500, 192000, 0x75f526cd
-0, 9000, 192000, 0x0f673577
-0, 10500, 192000, 0x897b6781
-1, 11988, 1850, 0xa9e48a74
-0, 12000, 192000, 0x81e6b7f7
-0, 13500, 192000, 0x1f45ce61
-0, 15000, 192000, 0x5a0772a6
-0, 16500, 192000, 0xf78732b3
-0, 18000, 192000, 0x8427f9e5
-1, 19481, 1480, 0x23ecd018
-0, 19500, 192000, 0x40473f11
-0, 21000, 192000, 0x173ceebe
-0, 22500, 192000, 0x136b9516
-0, 24000, 192000, 0x138d11ae
-1, 25475, 1480, 0x206bb915
-0, 25500, 192000, 0x063dbff3
-0, 27000, 192000, 0x5280852f
-0, 28500, 192000, 0x99943a8f
-0, 30000, 192000, 0x0330a728
-1, 31469, 1850, 0xb0e10e75
-0, 31500, 192000, 0x5d35467d
-0, 33000, 192000, 0xfd436343
-0, 34500, 192000, 0xc323fcfe
-0, 36000, 192000, 0x2a1530a0
-0, 37500, 192000, 0xbd43bb60
-1, 38961, 1480, 0x8d9baedd
-0, 39000, 192000, 0xa47f5eab
-0, 40500, 192000, 0xff17f5f7
-0, 42000, 192000, 0xb4140b55
-0, 43500, 192000, 0xb8782cc4
-1, 44955, 1480, 0xb802aae1
-0, 45000, 192000, 0x92975b8b
-0, 46500, 192000, 0xf42a64d6
-0, 48000, 192000, 0x2cc7077d
-0, 49500, 192000, 0x00080cc8
-1, 50950, 1480, 0xecd7b5cc
-0, 51000, 192000, 0x584b48f3
-0, 52500, 192000, 0xd68f57da
-0, 54000, 192000, 0x60158422
-0, 55500, 192000, 0xd7fb89e6
-1, 56944, 1850, 0x16861355
-0, 57000, 192000, 0x97f1c76a
-0, 58500, 192000, 0x46c4bb9e
-0, 60000, 192000, 0xd32f9b66
-0, 61500, 192000, 0x74f43886
-0, 63000, 192000, 0x3c4e47df
-1, 64436, 1480, 0xa51690bd
-0, 64500, 192000, 0xb5ac0a58
-0, 66000, 192000, 0xcc572b31
-0, 67500, 192000, 0xb1739d26
-0, 69000, 192000, 0x73da5473
-1, 70430, 1480, 0xdd0b90d1
-0, 70500, 192000, 0x5f79f5bc
-0, 72000, 192000, 0x0affc0a0
-0, 73500, 192000, 0x2b4d5c1c
-0, 75000, 192000, 0x309b41bc
-1, 76424, 1850, 0x3ce6e333
-0, 76500, 192000, 0xd42b6424
-0, 78000, 192000, 0x4795c948
-0, 79500, 192000, 0xbc1a3a8b
-0, 81000, 192000, 0x16529c5b
-0, 82500, 192000, 0x6b1b31ba
-1, 83917, 1480, 0xf8ce8ea3
-0, 84000, 192000, 0x569182ce
-0, 85500, 192000, 0xe6ea9866
-0, 87000, 192000, 0x102c6076
-0, 88500, 192000, 0xb29f527a
-1, 89911, 1480, 0xda4597af
-0, 90000, 192000, 0x040b4eee
-0, 91500, 192000, 0x92574f4a
-0, 93000, 192000, 0x1e8acdce
-0, 94500, 192000, 0x1becf516
-1, 95905, 1480, 0x918f7cb3
-0, 96000, 192000, 0xb62e9776
-0, 97500, 192000, 0xed37a08e
-0, 99000, 192000, 0xc0719912
-0, 100500, 192000, 0x24cf7a7e
-1, 101899, 1850, 0xca6edb15
-0, 102000, 192000, 0x0307f62f
-0, 103500, 192000, 0x79b7417b
-1, 109392, 1480, 0xba279597
-1, 115386, 1480, 0xc5a38a9e
-1, 121380, 1850, 0x8147eef5
-1, 128872, 1480, 0xce2c7cb5
-1, 134866, 1480, 0x4282819f
-1, 140860, 1480, 0xbdbb8da6
-1, 146854, 1850, 0xdbbeea10
-1, 154347, 1480, 0xbe6a77c2
-1, 160341, 1480, 0xa85c75b2
-1, 166335, 1850, 0xa45bde21
-1, 173828, 1480, 0x84aa7895
-1, 179822, 1480, 0x147f7d9f
-1, 185816, 1480, 0xc8e77b85
-1, 191810, 1850, 0x10d4d81b
-1, 199302, 1480, 0xb4ae8bb1
-1, 205297, 1480, 0x3ef782a5
-1, 211291, 1850, 0xdeebda14
-1, 218783, 1480, 0x4c7e7bbb
-1, 224777, 1480, 0x0e0e9198
-1, 230771, 1480, 0x5c1f819f
-1, 236765, 1850, 0x0e4cf6ff
-1, 244258, 1480, 0x374388a7
-1, 250252, 1480, 0xed729389
-1, 256246, 1850, 0xe0f1e43f
-1, 263739, 1480, 0x3b27839a
-1, 269733, 1480, 0xe6287e94
-1, 275727, 1480, 0x7e0d84b5
-1, 281721, 1850, 0xf08bebf7
-1, 289213, 1480, 0x94cf73a0
-1, 295207, 1480, 0xfef384ae
-1, 301202, 1850, 0x3b93e0f7
-1, 308694, 1480, 0x28d27bae
-1, 314688, 1480, 0x94d57da5
-1, 320682, 1480, 0xc9327db5
-1, 326676, 1850, 0xe781f604
-1, 334169, 1480, 0x752f8c5b
-1, 340163, 1480, 0x30068032
-1, 346157, 1850, 0x7895023e
-1, 353650, 1480, 0xa1e0a6e1
-1, 359644, 1480, 0x6af4b500
-1, 365638, 1480, 0xc26ea4c7
-1, 371632, 1850, 0x16a72419
-1, 379124, 1480, 0x1794aacc
-1, 385118, 1480, 0x2ecad8d0
-1, 391112, 1850, 0x2e645e07
-1, 398605, 1480, 0x1c54dfe7
-1, 404599, 1480, 0xbd35feec
-1, 410593, 1480, 0x419403d6
-1, 416587, 1850, 0x78699d2a
-1, 424080, 1480, 0x74ec68e0
-1, 430074, 1480, 0x76af64d9
-1, 436068, 1850, 0x5a303d1a
-1, 443560, 1074, 0x142ce7ba
-1, 447910, 1850, 0x7ff682f7
make: *** [fate-bethsoft-vid] Error 139
make: *** Waiting for unfinished jobs....
--- /home/siretart/libav/libav/tests/ref/fate/bfi       2011-05-21 
15:05:26.928798109 +0200
+++ tests/data/fate/bfi 2011-05-24 21:57:16.739211885 +0200
@@ -1,114 +0,0 @@
-0, 0, 134400, 0xc218b00c
-1, 0, 17768, 0x07df135c
-0, 10000, 134400, 0x114daf7c
-0, 20000, 134400, 0xe14db24c
-0, 30000, 134400, 0x88c71df7
-0, 40000, 134400, 0xc98c09fc
-0, 50000, 134400, 0xf7c2e7a9
-0, 60000, 134400, 0xf54f304f
-0, 70000, 134400, 0x67370fdd
-1, 72522, 2220, 0x44953646
-0, 80000, 134400, 0xe70f43cd
-1, 81584, 2220, 0x256b3329
-0, 90000, 134400, 0xad74c06f
-1, 90645, 2222, 0x344d20c6
-1, 99714, 2220, 0xd8ee20db
-0, 100000, 134400, 0xef42fdf2
-1, 108776, 2222, 0x46d70aa2
-0, 110000, 134400, 0xa14cc4b8
-1, 117845, 2220, 0xbe0a2213
-0, 120000, 134400, 0xc6e57381
-1, 126906, 2222, 0x4ee0fd07
-0, 130000, 134400, 0x74b4804b
-1, 135976, 2220, 0x709dfe87
-0, 140000, 134400, 0xe0863d6f
-1, 145037, 2222, 0xbb382521
-0, 150000, 134400, 0x90b6d03c
-1, 154106, 2220, 0x6dba1d2d
-0, 160000, 134400, 0x3d0409fd
-1, 163167, 2222, 0xbc4cdd6d
-0, 170000, 134400, 0xc02e09a4
-1, 172237, 2220, 0x54340d2c
-0, 180000, 134400, 0xa3515997
-1, 181298, 2220, 0x8925d335
-0, 190000, 134400, 0xc0fda122
-1, 190359, 2222, 0xa39bd15f
-1, 199429, 2220, 0x6875f632
-0, 200000, 134400, 0x5380d707
-1, 208490, 2222, 0xda46be57
-0, 210000, 134400, 0xcc19c085
-1, 217559, 2220, 0xd591eb44
-0, 220000, 134400, 0x8041e977
-1, 226620, 2222, 0x33afd17f
-0, 230000, 134400, 0xb96b2bea
-1, 235690, 2220, 0xd97be03b
-0, 240000, 134400, 0xcc977ca7
-1, 244751, 2222, 0x3b71e82e
-0, 250000, 134400, 0xe37abb34
-1, 253820, 2220, 0x95fbec2b
-0, 260000, 134400, 0xce488baa
-1, 262882, 2220, 0xae3a1c1e
-0, 270000, 134400, 0xa0734e8a
-1, 271943, 2222, 0x46cd0973
-0, 280000, 134400, 0x6b5ce0b0
-1, 281012, 2220, 0x7b28f3f6
-0, 290000, 134400, 0xf207f938
-1, 290073, 2222, 0xa2a5bc47
-1, 299143, 2220, 0x4727df63
-0, 300000, 134400, 0xe10060f8
-1, 308204, 2222, 0xdf53f4e2
-0, 310000, 134400, 0xaebe6b37
-1, 317273, 2220, 0x469c1e8f
-0, 320000, 134400, 0x08ea5c75
-1, 326335, 2222, 0x3c541799
-0, 330000, 134400, 0x05c6b514
-1, 335404, 2220, 0xc8d21fee
-0, 340000, 134400, 0x68cb3703
-1, 344465, 2222, 0x5f52126f
-0, 350000, 134400, 0x48867fd0
-1, 353535, 2220, 0x06a9ff18
-0, 360000, 134400, 0xc53eda30
-1, 362596, 2220, 0x84f9aa2b
-0, 370000, 134400, 0x0c1b198d
-1, 371657, 2222, 0xe0518c83
-0, 380000, 134400, 0xc8ac5bc8
-1, 380727, 2220, 0xc85ee26c
-1, 389788, 2222, 0xda23fd2d
-0, 390000, 134400, 0x9e35240d
-1, 398857, 2220, 0x7ee2e818
-0, 400000, 134400, 0x885d142f
-1, 407918, 2222, 0x45eb0465
-0, 410000, 134400, 0x207cb4ac
-1, 416988, 2220, 0xf3e90549
-0, 420000, 134400, 0x0abe748b
-1, 426049, 2222, 0x17aacf3d
-0, 430000, 134400, 0xf13e991b
-1, 435118, 2220, 0x6cb7e325
-0, 440000, 134400, 0x2544248d
-1, 444180, 2220, 0x20164553
-0, 450000, 134400, 0x5444bb22
-1, 453241, 2222, 0x00000000
-0, 460000, 134400, 0xc5a8f55a
-1, 462310, 2220, 0x00000000
-0, 470000, 134400, 0xe6006820
-1, 471371, 2222, 0x00000000
-0, 480000, 134400, 0x2a34239d
-1, 480441, 2220, 0x00000000
-1, 489502, 2222, 0x00000000
-0, 490000, 134400, 0x26deac5b
-1, 498571, 2220, 0x00000000
-0, 500000, 134400, 0x82c2c0a9
-1, 507633, 2222, 0x00000000
-0, 510000, 134400, 0xcdd8daba
-1, 516702, 2450, 0x00000000
-0, 520000, 134400, 0x5a1a2105
-1, 526702, 2450, 0x00000000
-0, 530000, 134400, 0x2ad43604
-1, 536702, 2450, 0x00000000
-0, 540000, 134400, 0xa9b58f35
-1, 546702, 2450, 0x00000000
-0, 550000, 134400, 0x0e37a7a8
-1, 556702, 2450, 0x00000000
-0, 560000, 134400, 0xd288eef7
-1, 566702, 2450, 0x00000000
-1, 576702, 2450, 0x00000000
make: *** [fate-bfi] Error 139

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to